From 189790371163cd778f66ff2b908a65f928d3f261 Mon Sep 17 00:00:00 2001 From: Ryan Young Date: Sat, 3 Sep 2022 15:29:41 +0000 Subject: [PATCH 1/2] build: update development container configuration Bump Node version, delete obsolete setting, fix npm error, run as a non-root user. --- .devcontainer/devcontainer.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index fcfad7738..899f4b1c3 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,14 +1,12 @@ { "name": "TypeScriptToLua", - "image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:14", - "settings": { - "terminal.integrated.shell.linux": "/bin/bash" - }, + "image": "mcr.microsoft.com/vscode/devcontainers/javascript-node:18", "extensions": [ "typescript-to-lua.vscode-typescript-to-lua", "dbaeumer.vscode-eslint", "editorconfig.editorconfig", "esbenp.prettier-vscode" ], - "postCreateCommand": "npm ci" + "postCreateCommand": "npm ci --legacy-peer-deps", + "remoteUser": "node" } From 7475879102e569614539a4b92378b62095eeca7c Mon Sep 17 00:00:00 2001 From: Ryan Young Date: Sat, 3 Sep 2022 15:44:59 +0000 Subject: [PATCH 2/2] build: remove legacy-peer-deps from the dev container --- .devcontainer/devcontainer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 899f4b1c3..45207b077 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -7,6 +7,6 @@ "editorconfig.editorconfig", "esbenp.prettier-vscode" ], - "postCreateCommand": "npm ci --legacy-peer-deps", + "postCreateCommand": "npm ci", "remoteUser": "node" }