From 41098a7312e7117fdf72923883122b92e2d8c8fc Mon Sep 17 00:00:00 2001 From: Perryvw Date: Mon, 26 Apr 2021 17:17:33 +0200 Subject: [PATCH] Fix missing stringaccess lualib dependency --- src/LuaLib.ts | 2 +- test/unit/builtins/string.spec.ts | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/LuaLib.ts b/src/LuaLib.ts index 06742022d..dc4501d86 100644 --- a/src/LuaLib.ts +++ b/src/LuaLib.ts @@ -106,7 +106,7 @@ const luaLibDependencies: Partial> = { WeakMap: [LuaLibFeature.InstanceOf, LuaLibFeature.Iterator, LuaLibFeature.Symbol, LuaLibFeature.Class], WeakSet: [LuaLibFeature.InstanceOf, LuaLibFeature.Iterator, LuaLibFeature.Symbol, LuaLibFeature.Class], Spread: [LuaLibFeature.Iterator, LuaLibFeature.Unpack], - StringSplit: [LuaLibFeature.StringSubstring], + StringSplit: [LuaLibFeature.StringSubstring, LuaLibFeature.StringAccess], SymbolRegistry: [LuaLibFeature.Symbol], }; /* eslint-enable @typescript-eslint/naming-convention */ diff --git a/test/unit/builtins/string.spec.ts b/test/unit/builtins/string.spec.ts index 5e1790573..c31ef012f 100644 --- a/test/unit/builtins/string.spec.ts +++ b/test/unit/builtins/string.spec.ts @@ -200,6 +200,13 @@ test("string.split inline", () => { .expectToMatchJsResult(); }); +// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1009 +test("string.split inline empty separator", () => { + util.testExpression`"a, b, c".split("")` + .setOptions({ luaLibImport: LuaLibImportKind.Inline }) + .expectToMatchJsResult(); +}); + test.each([ { inp: "hello test", index: 0 }, { inp: "hello test", index: 1 },