Fix bug with using dispose when using disposable class (#1586)

Perryvw · web-flow · commit b40b43c2b7cb · 2024-09-21T20:18:12.000+02:00
diff --git a/src/lualib/Using.ts b/src/lualib/Using.ts
@@ -1,6 +1,6 @@
 export function __TS__Using<TArgs extends Disposable[], TReturn>(
     this: undefined,
-    cb: (...args: TArgs) => TReturn,
+    cb: (this: void, ...args: TArgs) => TReturn,
     ...args: TArgs
 ): TReturn {
     let thrownError;
diff --git a/test/unit/using.spec.ts b/test/unit/using.spec.ts
@@ -193,3 +193,27 @@ test("await using no extra diagnostics (#1571)", () => {
         }
     `.expectToHaveNoDiagnostics();
 });
+
+// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1584
+test("works with disposable classes (#1584)", () => {
+    util.testFunction`
+        const log = [];
+        
+        class Scoped {
+            action(): void {
+                log.push("action")
+            }
+            [Symbol.dispose]() {
+                log.push("cleanup")
+            }
+        }
+
+        function TestScoped(): void {
+            using s = new Scoped();
+            s.action();
+        }
+
+        TestScoped();
+        return log;
+    `.expectToEqual(["action", "cleanup"]);
+});
