Skip to content

Commit 89bc7bb

Browse files
tomblindtomblind
committed
simplified tests
1 parent f744a37 commit 89bc7bb

1 file changed

Lines changed: 24 additions & 32 deletions

File tree

‎test/unit/typechecking.spec.ts‎

Lines changed: 24 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -142,50 +142,42 @@ test("instanceof Symbol.hasInstance", () => {
142142
});
143143

144144
test.each([
145-
{ expression: "{}", operator: "===", compareTo: "object", expectResult: "TRUE" },
146-
{ expression: "{}", operator: "!==", compareTo: "object", expectResult: "FALSE" },
147-
{ expression: "{}", operator: "==", compareTo: "object", expectResult: "TRUE" },
148-
{ expression: "{}", operator: "!=", compareTo: "object", expectResult: "FALSE" },
149-
{ expression: "{}", operator: "<=", compareTo: "object", expectResult: "TRUE" },
150-
{ expression: "{}", operator: "<", compareTo: "object", expectResult: "FALSE" },
151-
{ expression: "undefined", operator: "===", compareTo: "undefined", expectResult: "TRUE" },
152-
{ expression: "() => {}", operator: "===", compareTo: "function", expectResult: "TRUE" },
153-
{ expression: "1", operator: "===", compareTo: "number", expectResult: "TRUE" },
154-
{ expression: "true", operator: "===", compareTo: "boolean", expectResult: "TRUE" },
155-
{ expression: `"foo"`, operator: "===", compareTo: "string", expectResult: "TRUE" },
145+
{ expression: "{}", operator: "===", compareTo: "object", expectResult: true },
146+
{ expression: "{}", operator: "!==", compareTo: "object", expectResult: false },
147+
{ expression: "{}", operator: "==", compareTo: "object", expectResult: true },
148+
{ expression: "{}", operator: "!=", compareTo: "object", expectResult: false },
149+
{ expression: "{}", operator: "<=", compareTo: "object", expectResult: true },
150+
{ expression: "{}", operator: "<", compareTo: "object", expectResult: false },
151+
{ expression: "undefined", operator: "===", compareTo: "undefined", expectResult: true },
152+
{ expression: "() => {}", operator: "===", compareTo: "function", expectResult: true },
153+
{ expression: "1", operator: "===", compareTo: "number", expectResult: true },
154+
{ expression: "true", operator: "===", compareTo: "boolean", expectResult: true },
155+
{ expression: `"foo"`, operator: "===", compareTo: "string", expectResult: true },
156156
])("typeof literal comparison (%p)", ({ expression, operator, compareTo, expectResult }) => {
157157
const code = `
158158
let val = ${expression};
159-
if (typeof val ${operator} "${compareTo}") {
160-
return "TRUE";
161-
} else {
162-
return "FALSE";
163-
}`;
159+
return typeof val ${operator} "${compareTo}";`;
164160

165161
expect(util.transpileAndExecute(code)).toBe(expectResult);
166162
});
167163

168164
test.each([
169-
{ expression: "{}", operator: "===", compareTo: "object", expectResult: "TRUE" },
170-
{ expression: "{}", operator: "!==", compareTo: "object", expectResult: "FALSE" },
171-
{ expression: "{}", operator: "==", compareTo: "object", expectResult: "TRUE" },
172-
{ expression: "{}", operator: "!=", compareTo: "object", expectResult: "FALSE" },
173-
{ expression: "{}", operator: "<=", compareTo: "object", expectResult: "TRUE" },
174-
{ expression: "{}", operator: "<", compareTo: "object", expectResult: "FALSE" },
175-
{ expression: "undefined", operator: "===", compareTo: "undefined", expectResult: "TRUE" },
176-
{ expression: "() => {}", operator: "===", compareTo: "function", expectResult: "TRUE" },
177-
{ expression: "1", operator: "===", compareTo: "number", expectResult: "TRUE" },
178-
{ expression: "true", operator: "===", compareTo: "boolean", expectResult: "TRUE" },
179-
{ expression: `"foo"`, operator: "===", compareTo: "string", expectResult: "TRUE" },
165+
{ expression: "{}", operator: "===", compareTo: "object", expectResult: true },
166+
{ expression: "{}", operator: "!==", compareTo: "object", expectResult: false },
167+
{ expression: "{}", operator: "==", compareTo: "object", expectResult: true },
168+
{ expression: "{}", operator: "!=", compareTo: "object", expectResult: false },
169+
{ expression: "{}", operator: "<=", compareTo: "object", expectResult: true },
170+
{ expression: "{}", operator: "<", compareTo: "object", expectResult: false },
171+
{ expression: "undefined", operator: "===", compareTo: "undefined", expectResult: true },
172+
{ expression: "() => {}", operator: "===", compareTo: "function", expectResult: true },
173+
{ expression: "1", operator: "===", compareTo: "number", expectResult: true },
174+
{ expression: "true", operator: "===", compareTo: "boolean", expectResult: true },
175+
{ expression: `"foo"`, operator: "===", compareTo: "string", expectResult: true },
180176
])("typeof non-literal comparison (%p)", ({ expression, operator, compareTo, expectResult }) => {
181177
const code = `
182178
let val = ${expression};
183179
let compareTo = "${compareTo}";
184-
if (typeof val ${operator} compareTo) {
185-
return "TRUE";
186-
} else {
187-
return "FALSE";
188-
}`;
180+
return typeof val ${operator} compareTo;`;
189181

190182
expect(util.transpileAndExecute(code)).toBe(expectResult);
191183
});

0 commit comments

Comments
 (0)