From dbdae971e89673ef08f85ed545394c78abfc0274 Mon Sep 17 00:00:00 2001 From: Ryan Fogle Date: Wed, 24 May 2023 20:24:57 -0400 Subject: [PATCH] filter out closeMenu from the props so React stops warning about it --- .../components/DragHandleMenuItem.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/react/src/BlockSideMenu/components/DragHandleMenuItem.tsx b/packages/react/src/BlockSideMenu/components/DragHandleMenuItem.tsx index b99774fb4a..f8ce980238 100644 --- a/packages/react/src/BlockSideMenu/components/DragHandleMenuItem.tsx +++ b/packages/react/src/BlockSideMenu/components/DragHandleMenuItem.tsx @@ -5,13 +5,14 @@ export type DragHandleMenuItemProps = PolymorphicComponentProps<"button"> & { closeMenu: () => void; }; -export const DragHandleMenuItem = (props: DragHandleMenuItemProps) => ( - { + const {closeMenu, onClick, ...propsToPassThrough} = props; + return { - props.closeMenu(); - props.onClick?.(event); + closeMenu(); + onClick?.(event); }}> {props.children} - -); + ; +};