fix: Parse new lines in text/plain as line breaks (BLO-1170) (#2712)

matthewlipski · web-flow · commit a77c8875d777 · 2026-05-06T17:06:40.000+02:00
* Made single new lines in Markdown get parsed as line breaks

* Removed logs

* Updated logic &amp; tests for new Markdown to HTML converter

* Removed unused snapshot

* Reverted lock file
diff --git a/packages/core/src/api/parsers/markdown/markdownToHtml.ts b/packages/core/src/api/parsers/markdown/markdownToHtml.ts
@@ -139,7 +139,7 @@ function trySoftBreak(
   i: number
 ): { html: string; end: number } | null {
   if (text[i] === "\n") {
-    return { html: "\n", end: i + 1 };
+    return { html: "<br>\n", end: i + 1 };
   }
   return null;
 }
diff --git a/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/blockquoteLazyContinuation.json b/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/blockquoteLazyContinuation.json
@@ -4,7 +4,9 @@
     "content": [
       {
         "styles": {},
-        "text": "This is a quote that continues here and here too",
+        "text": "This is a quote
+ that continues here
+ and here too",
         "type": "text",
       },
     ],
diff --git a/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/blockquoteMultiline.json b/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/blockquoteMultiline.json
@@ -4,7 +4,9 @@
     "content": [
       {
         "styles": {},
-        "text": "Line one Line two Line three",
+        "text": "Line one
+ Line two
+ Line three",
         "type": "text",
       },
     ],
diff --git a/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/lineBreaks.json b/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/lineBreaks.json
@@ -4,7 +4,9 @@
     "content": [
       {
         "styles": {},
-        "text": "Line one still same paragraph",
+        "text": "Line one
+ Line two
+ Line three",
         "type": "text",
       },
     ],
diff --git a/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/paragraphLeadingIndent.json b/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/paragraphLeadingIndent.json
@@ -4,7 +4,8 @@
     "content": [
       {
         "styles": {},
-        "text": "aaa bbb",
+        "text": "aaa
+ bbb",
         "type": "text",
       },
     ],
diff --git a/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/singleNewLines.json b/tests/src/unit/core/formatConversion/parse/__snapshots__/markdown/singleNewLines.json
@@ -0,0 +1,22 @@
+[
+  {
+    "children": [],
+    "content": [
+      {
+        "styles": {},
+        "text": "Line 1
+ Line 2
+ Line 3
+ Line 4",
+        "type": "text",
+      },
+    ],
+    "id": "1",
+    "props": {
+      "backgroundColor": "default",
+      "textAlignment": "left",
+      "textColor": "default",
+    },
+    "type": "paragraph",
+  },
+]
diff --git a/tests/src/unit/core/formatConversion/parse/parseTestInstances.ts b/tests/src/unit/core/formatConversion/parse/parseTestInstances.ts
@@ -1689,12 +1689,13 @@ Third paragraph`,
     },
     executeTest: testParseMarkdown,
   },
-  // Paragraph continuation (lines without blank line)
+  // Line breaks
   {
     testCase: {
-      name: "paragraphContinuation",
+      name: "lineBreaks",
       content: `Line one
-still same paragraph`,
+Line two
+Line three`,
     },
     executeTest: testParseMarkdown,
   },

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ function trySoftBreak(`
`139`	`139`	`i: number`
`140`	`140`	`): { html: string; end: number } \| null {`
`141`	`141`	`if (text[i] === "\n") {`
`142`		`- return { html: "\n", end: i + 1 };`
	`142`	`+ return { html: "<br>\n", end: i + 1 };`
`143`	`143`	`}`
`144`	`144`	`return null;`
`145`	`145`	`}`