Skip to content

Commit 23a3bc0

Browse files
gregmagolangregmagolan
committed
test: move internal/e2e rollup tests to internal/rollup/test
1 parent bc5c8e5 commit 23a3bc0

67 files changed

Lines changed: 39 additions & 36 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.bazelci/presubmit.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ tasks:
99
- "//internal/node/test:has_deps_legacy"
1010
- "//internal/node/test:has_deps"
1111
- "//internal/node/test:has_deps_hybrid"
12-
- "//internal/e2e/fine_grained_no_bin:index"
12+
- "//internal/npm_install/test:index"
1313
- "@fine_grained_deps_yarn//typescript/bin:tsc"
1414
- "@bazel_workspace_a//:bin"
1515
- "@bazel_workspace_a//subdir:bin"
@@ -91,7 +91,7 @@ tasks:
9191
- "//internal/node/test:has_deps_legacy"
9292
- "//internal/node/test:has_deps"
9393
- "//internal/node/test:has_deps_hybrid"
94-
- "//internal/e2e/fine_grained_no_bin:index"
94+
- "//internal/npm_install/test:index"
9595
- "@fine_grained_deps_yarn//typescript/bin:tsc"
9696
- "@bazel_workspace_a//:bin"
9797
- "@bazel_workspace_a//subdir:bin"
@@ -186,7 +186,7 @@ tasks:
186186
- "//internal/node/test:has_deps_legacy"
187187
- "//internal/node/test:has_deps"
188188
- "//internal/node/test:has_deps_hybrid"
189-
- "//internal/e2e/fine_grained_no_bin:index"
189+
- "//internal/npm_install/test:index"
190190
- "@fine_grained_deps_yarn//typescript/bin:tsc"
191191
- "@bazel_workspace_a//:bin"
192192
- "@bazel_workspace_a//subdir:bin"
@@ -286,7 +286,7 @@ tasks:
286286
- "//internal/node/test:has_deps_legacy"
287287
- "//internal/node/test:has_deps"
288288
- "//internal/node/test:has_deps_hybrid"
289-
- "//internal/e2e/fine_grained_no_bin:index"
289+
- "//internal/npm_install/test:index"
290290
- "@fine_grained_deps_yarn//typescript/bin:tsc"
291291
- "@bazel_workspace_a//:bin"
292292
- "@bazel_workspace_a//subdir:bin"

‎.circleci/config.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ jobs:
264264
- run: bazel run //internal/node/test:has_deps
265265
- run: bazel run //internal/node/test:has_deps_hybrid
266266
- run: bazel run //internal/node/test:module_name_test
267-
- run: bazel run //internal/e2e/fine_grained_no_bin:index
267+
- run: bazel run //internal/npm_install/test:index
268268
- run: bazel run @fine_grained_deps_yarn//typescript/bin:tsc
269269
- run: bazel run @bazel_workspace_a//:bin
270270
- run: bazel run @bazel_workspace_a//subdir:bin

‎docs/Built-ins.md‎

Lines changed: 1 addition & 1 deletion

‎internal/e2e/rollup/bundle-min_golden.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎internal/npm_install/generate_build_file.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ function listFiles(rootDir, subDir = '') {
411411
// which leads to Bazel targets that cross package boundaries.
412412
// See https://github.com/bazelbuild/rules_nodejs/issues/428 and
413413
// https://github.com/bazelbuild/rules_nodejs/issues/438.
414-
// This is tested in internal/e2e/fine_grained_symlinks.
414+
// This is tested in /e2e/fine_grained_symlinks.
415415
return files;
416416
}
417417
return isDirectory ? files.concat(listFiles(rootDir, relPath)) : files.concat(relPath);

‎internal/rollup/rollup_bundle.bzl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -844,7 +844,7 @@ See https://github.com/bazelbuild/rules_nodejs/issues/175
844844
845845
For debugging, note that the `rollup.config.js` and `terser.config.json` files can be found in the bazel-bin folder next to the resulting bundle.
846846
847-
An example usage can be found in https://github.com/bazelbuild/rules_nodejs/tree/master/internal/e2e/rollup
847+
An example usage can be found in https://github.com/bazelbuild/rules_nodejs/tree/master/internal/rollup/test/rollup
848848
""",
849849
outputs = ROLLUP_OUTPUTS,
850850
)

internal/e2e/BUILD.bazel renamed to internal/rollup/test/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ js_library(
66
name = "check_lib",
77
srcs = ["check.js"],
88
module_name = "check",
9+
module_root = "check.js",
910
)

internal/e2e/check.js renamed to internal/rollup/test/check.js

File renamed without changes.

internal/e2e/rollup/BUILD.bazel renamed to internal/rollup/test/rollup/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ rollup_bundle(
99
globals = {"some_global_var": "runtime_name_of_global_var"},
1010
license_banner = ":license.txt",
1111
deps = [
12-
"//internal/e2e/rollup/fum:fumlib",
12+
"//internal/rollup/test/rollup/fum:fumlib",
1313
"@npm//hello",
1414
],
1515
)
@@ -30,7 +30,7 @@ jasmine_node_test(
3030
":bundle.min_debug.js",
3131
],
3232
deps = [
33-
"//internal/e2e:check_lib",
33+
"//internal/rollup/test:check_lib",
3434
"@npm//unidiff",
3535
],
3636
)

internal/e2e/rollup/bar.js renamed to internal/rollup/test/rollup/bar.js

File renamed without changes.

0 commit comments

Comments
 (0)