Skip to content

Commit 012a21e

Browse files
gregmagolanalexeagle
authored andcommitted
Minimum Bazel version is now 0.26.0 as yarn_install & npm_install depend on managed_directories by default (bazel-contrib#704)
1 parent c91b87c commit 012a21e

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎WORKSPACE‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ load("//internal/common:check_bazel_version.bzl", "check_bazel_version")
3030

3131
# 0.18.0: support for .bazelignore
3232
# 0.23.0: required fix for pkg_tar strip_prefix
33-
check_bazel_version(minimum_bazel_version = "0.23.0")
33+
# 0.26.0: managed_directories feature added
34+
check_bazel_version(minimum_bazel_version = "0.26.0")
3435

3536
#
3637
# Load and install our dependencies downloaded above.

‎internal/common/check_bazel_version.bzl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def check_bazel_version(minimum_bazel_version, message = ""):
3535
```
3636
# in WORKSPACE:
3737
load("@build_bazel_rules_nodejs//:defs.bzl", "check_bazel_version")
38-
check_bazel_version("0.11.0")
38+
check_bazel_version("0.26.0")
3939
```
4040
4141
Args:

‎internal/node/node_repositories.bzl‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,8 @@ def node_repositories(
535535
# 0.14.0: @bazel_tools//tools/bash/runfiles is required for nodejs
536536
# 0.17.1: allow @ in package names is required for fine grained deps
537537
# 0.21.0: repository_ctx.report_progress API
538-
check_bazel_version("0.21.0")
538+
# 0.26.0: managed_directories feature added
539+
check_bazel_version("0.26.0")
539540

540541
_maybe(
541542
_nodejs_repo,

0 commit comments

Comments
 (0)