build: zlib build error on Windows on Arm

richard-townsend-arm · Trott · commit d9ba0687e0fd · 2021-04-15T21:12:38.000-07:00
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the C versions for now. PR-URL: nodejs#33511 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -1605,7 +1605,13 @@
           'toolsets': ['host', 'target'],
         }],
         ['OS=="win"', {
-          'defines': ['X86_WINDOWS'],
+          'conditions': [
+            ['"<(target_arch)"=="arm64" and _toolset=="target"', {
+              'defines': ['CPU_NO_SIMD']
+            }, {
+              'defines': ['X86_WINDOWS']
+            }]
+          ]
         }],
       ],
       'direct_dependent_settings': {
