Fix handling of HTML boolean attributes

terrill · terrill · commit 65f06d432ce2 · 2018-03-12T13:04:57.000-07:00
diff --git a/build/ableplayer.dist.js b/build/ableplayer.dist.js
@@ -79,16 +79,16 @@
 
     // The following variables CAN be overridden with HTML attributes
 
-    // autoplay
+    // autoplay (Boolean; if present always resolves to true, regardless of value)
     if ($(media).attr('autoplay') !== undefined) {
       this.autoplay = true;
     }
     else {
       this.autoplay = false;
     }
 
-    // loop (NOT FULLY SUPPORTED)
-    if ($(media).attr('loop') !== undefined && $(media).attr('loop') !== false) {
+    // loop (Boolean; if present always resolves to true, regardless of value)
+    if ($(media).attr('loop') !== undefined) {
       this.loop = true;
     }
     else {
diff --git a/build/ableplayer.js b/build/ableplayer.js
@@ -79,16 +79,16 @@
 
     // The following variables CAN be overridden with HTML attributes
 
-    // autoplay
+    // autoplay (Boolean; if present always resolves to true, regardless of value)
     if ($(media).attr('autoplay') !== undefined) {
       this.autoplay = true;
     }
     else {
       this.autoplay = false;
     }
 
-    // loop (NOT FULLY SUPPORTED)
-    if ($(media).attr('loop') !== undefined && $(media).attr('loop') !== false) {
+    // loop (Boolean; if present always resolves to true, regardless of value)
+    if ($(media).attr('loop') !== undefined) {
       this.loop = true;
     }
     else {
diff --git a/build/ableplayer.min.css b/build/ableplayer.min.css
diff --git a/build/ableplayer.min.js b/build/ableplayer.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "ableplayer",
-  "version": "3.0.40",
+  "version": "3.0.41",
   "description": "fully accessible HTML5 media player",
   "homepage": "http://ableplayer.github.io/ableplayer",
   "bugs": "https://github.com/ableplayer/ableplayer/issues",
diff --git a/scripts/ableplayer-base.js b/scripts/ableplayer-base.js
@@ -79,16 +79,16 @@
 
     // The following variables CAN be overridden with HTML attributes
 
-    // autoplay
+    // autoplay (Boolean; if present always resolves to true, regardless of value)
     if ($(media).attr('autoplay') !== undefined) {
       this.autoplay = true;
     }
     else {
       this.autoplay = false;
     }
 
-    // loop (NOT FULLY SUPPORTED)
-    if ($(media).attr('loop') !== undefined && $(media).attr('loop') !== false) {
+    // loop (Boolean; if present always resolves to true, regardless of value)
+    if ($(media).attr('loop') !== undefined) {
       this.loop = true;
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -79,16 +79,16 @@`
`79`	`79`
`80`	`80`	`// The following variables CAN be overridden with HTML attributes`
`81`	`81`
`82`		`- // autoplay`
	`82`	`+ // autoplay (Boolean; if present always resolves to true, regardless of value)`
`83`	`83`	`if ($(media).attr('autoplay') !== undefined) {`
`84`	`84`	`this.autoplay = true;`
`85`	`85`	`}`
`86`	`86`	`else {`
`87`	`87`	`this.autoplay = false;`
`88`	`88`	`}`
`89`	`89`
`90`		`- // loop (NOT FULLY SUPPORTED)`
`91`		`- if ($(media).attr('loop') !== undefined && $(media).attr('loop') !== false) {`
	`90`	`+ // loop (Boolean; if present always resolves to true, regardless of value)`
	`91`	`+ if ($(media).attr('loop') !== undefined) {`
`92`	`92`	`this.loop = true;`
`93`	`93`	`}`
`94`	`94`	`else {`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ableplayer",`
`3`		`- "version": "3.0.40",`
	`3`	`+ "version": "3.0.41",`
`4`	`4`	`"description": "fully accessible HTML5 media player",`
`5`	`5`	`"homepage": "http://ableplayer.github.io/ableplayer",`
`6`	`6`	`"bugs": "https://github.com/ableplayer/ableplayer/issues",`