docs: fix Bigtable flakey filters test (GoogleCloudPlatform#8523)

billyjacobson · web-flow · commit e15dfae43f5f · 2023-08-09T19:44:12.000Z
## Description Updated the table creation to remove any garbage collection. Default for most Bigtable clients is none, but for HBase client it was 1 max version for consistency with HBase API. Fixes https://togithub.com/GoogleCloudPlatform/java-docs-samples/issues/7963 Fixes https://togithub.com/GoogleCloudPlatform/java-docs-samples/issues/7964 Fixes https://togithub.com/GoogleCloudPlatform/java-docs-samples/issues/7965 Fixes https://togithub.com/GoogleCloudPlatform/java-docs-samples/issues/7966 Fixes https://togithub.com/GoogleCloudPlatform/java-docs-samples/issues/7967 Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google. ## Checklist - [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample - [ ] This sample adds a new **Product API**, and I updated the [Blunderbuss issue/PR auto-assigner](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/.github/blunderbuss.yml) with the codeowners for this sample - [ ] Please **merge** this PR for me once it is approved
diff --git a/bigtable/hbase/snippets/src/test/java/com/example/bigtable/FiltersTest.java b/bigtable/hbase/snippets/src/test/java/com/example/bigtable/FiltersTest.java
@@ -44,7 +44,8 @@
 
 public class FiltersTest {
 
-  @Rule public final MultipleAttemptsRule multipleAttemptsRule = new MultipleAttemptsRule(5);
+  @Rule
+  public final MultipleAttemptsRule multipleAttemptsRule = new MultipleAttemptsRule(5);
 
   private static final String INSTANCE_ENV = "BIGTABLE_TESTING_INSTANCE";
   private static final String TABLE_ID =
@@ -77,8 +78,10 @@ public static void beforeClass() throws IOException {
       try (Admin admin = connection.getAdmin()) {
         admin.createTable(
             new HTableDescriptor(TableName.valueOf(TABLE_ID))
-                .addFamily(new HColumnDescriptor(COLUMN_FAMILY_NAME_STATS))
-                .addFamily(new HColumnDescriptor(COLUMN_FAMILY_NAME_DATA)));
+                .addFamily(new HColumnDescriptor(COLUMN_FAMILY_NAME_STATS).setMaxVersions(
+                    Integer.MAX_VALUE))
+                .addFamily(new HColumnDescriptor(COLUMN_FAMILY_NAME_DATA).setMaxVersions(
+                    Integer.MAX_VALUE)));
 
         try (BufferedMutator batcher = connection.getBufferedMutator(TableName.valueOf(TABLE_ID))) {
 
@@ -597,4 +600,4 @@ public void testFilterInterleave() {
                     + "\tos_build: PQ2A.190406.000 @%1$s",
                 TIMESTAMP, TIMESTAMP_MINUS_HR));
   }
-}
+}
