Merge pull request docker-java#1112 from silvestre/master

KostyaSha · web-flow · commit e1957d7efff8 · 2018-10-15T16:53:28.000+03:00
Add HostConfig.StorageOpt and ExecCreateCmd.Env
diff --git a/src/main/java/com/github/dockerjava/api/command/ExecCreateCmd.java b/src/main/java/com/github/dockerjava/api/command/ExecCreateCmd.java
@@ -1,5 +1,7 @@
 package com.github.dockerjava.api.command;
 
+import java.util.List;
+
 import javax.annotation.CheckForNull;
 import javax.annotation.Nonnull;
 
@@ -20,6 +22,9 @@ public interface ExecCreateCmd extends SyncDockerCmd<ExecCreateCmdResponse> {
     @CheckForNull
     Boolean hasTtyEnabled();
 
+    @CheckForNull
+    List<String> getEnv();
+
     @CheckForNull
     String getUser();
 
@@ -37,6 +42,8 @@ public interface ExecCreateCmd extends SyncDockerCmd<ExecCreateCmdResponse> {
 
     ExecCreateCmd withCmd(String... cmd);
 
+    ExecCreateCmd withEnv(List<String> env);
+
     ExecCreateCmd withContainerId(@Nonnull String containerId);
 
     ExecCreateCmd withTty(Boolean tty);
diff --git a/src/main/java/com/github/dockerjava/api/model/HostConfig.java b/src/main/java/com/github/dockerjava/api/model/HostConfig.java
@@ -185,6 +185,12 @@ public class HostConfig implements Serializable {
     @JsonProperty("RestartPolicy")
     private RestartPolicy restartPolicy;
 
+    /**
+     * @since {@link RemoteApiVersion#VERSION_1_24}
+     */
+    @JsonProperty("StorageOpt")
+    private Map<String, String> storageOpt;
+
     @JsonProperty("Ulimits")
     private Ulimit[] ulimits;
 
@@ -929,6 +935,21 @@ public HostConfig withRestartPolicy(RestartPolicy restartPolicy) {
         return this;
     }
 
+    /**
+     * @see #storageOpt
+     */
+    public Map<String, String> getStorageOpt() {
+        return storageOpt;
+    }
+
+    /**
+     * @see #storageOpt
+     */
+    public HostConfig withStorageOpt(Map<String, String> storageOpt) {
+        this.storageOpt = storageOpt;
+        return this;
+    }
+
     /**
      * @see #securityOpts
      */
diff --git a/src/main/java/com/github/dockerjava/core/command/ExecCreateCmdImpl.java b/src/main/java/com/github/dockerjava/core/command/ExecCreateCmdImpl.java
@@ -2,6 +2,8 @@
 
 import static com.google.common.base.Preconditions.checkNotNull;
 
+import java.util.List;
+
 import com.fasterxml.jackson.annotation.JsonInclude;
 import com.fasterxml.jackson.annotation.JsonInclude.Include;
 import com.fasterxml.jackson.annotation.JsonProperty;
@@ -41,6 +43,12 @@ public class ExecCreateCmdImpl extends AbstrDockerCmd<ExecCreateCmd, ExecCreateC
     @JsonProperty("Cmd")
     private String[] cmd;
 
+    /**
+     * @since {@link com.github.dockerjava.core.RemoteApiVersion#VERSION_1_25}
+     */
+    @JsonProperty("Env")
+    private List<String> env;
+
     /**
      * @since {@link com.github.dockerjava.core.RemoteApiVersion#VERSION_1_35}
      */
@@ -95,6 +103,12 @@ public ExecCreateCmd withCmd(String... cmd) {
         return this;
     }
 
+    @Override
+    public ExecCreateCmd withEnv(List<String> env) {
+        this.env = env;
+        return this;
+    }
+
     @Override
     public ExecCreateCmd withPrivileged(Boolean privileged) {
         this.privileged = privileged;
@@ -132,6 +146,11 @@ public Boolean hasTtyEnabled() {
         return tty;
     }
 
+    @Override
+    public List<String> getEnv() {
+        return env;
+    }
+
     @Override
     public Boolean getPrivileged() {
         return privileged;
