-
-
Notifications
You must be signed in to change notification settings - Fork 50.7k
Non-pythonic code #3
Copy link
Copy link
Closed
Labels
enhancementThis PR modified some existing filesThis PR modified some existing files
Metadata
Metadata
Assignees
Labels
enhancementThis PR modified some existing filesThis PR modified some existing files
Type
Fields
Give feedbackNo fields configured for issues without a type.
Code shown in this repository is mostly non-pythonic. It doesn't follow any conventions from PEP8 and all algorithms have a lot of anti-patterns. For example, binary search as shown in Python docs -- https://docs.python.org/3/library/bisect.html#searching-sorted-lists.
I don't know the exact purpose of this repository, but it certainly doesn't show well-implemented basic algorithms in Python.