Rename and relocate trie autocomplete implementation#7459
Open
Chandu0501 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7459 +/- ##
============================================
+ Coverage 79.72% 79.73% +0.01%
- Complexity 7296 7297 +1
============================================
Files 803 803
Lines 23762 23762
Branches 4674 4672 -2
============================================
+ Hits 18944 18947 +3
+ Misses 4059 4058 -1
+ Partials 759 757 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7457
This moves the trie autocomplete implementation into the
datastructures.treespackage and renames its file and class toTrieAutocomplete, following Java naming conventions. The matching PMD exclusion now references the renamed class.There was no existing matching test class to rename, and this change does not alter algorithm behavior.
Verification:
mvn test(9,310 tests passed)mvn -q checkstyle:checkmvn -q spotbugs:checkPMD note:
mvn -q pmd:checkcould not start on this Windows checkout because the repository'sfile://${basedir}custom ruleset URI resolves as an unsupported Windowsfile://resource path.clang-format -i --style=file path/to/your/file.java(No new code; rename/package update only.)