fix: handle Null Dereference in UnitsConverter

vil02 · vil02 · commit 8cf21f7d66e2 · 2024-09-22T10:44:57.000+02:00
diff --git a/.inferconfig b/.inferconfig
@@ -2,7 +2,6 @@
     "report-block-list-path-regex": [
         "src/main/java/com/thealgorithms/ciphers/a5/CompositeLFSR.java",
         "src/main/java/com/thealgorithms/conversions/RomanToInteger.java",
-        "src/main/java/com/thealgorithms/conversions/UnitsConverter.java",
         "src/main/java/com/thealgorithms/datastructures/crdt/GCounter.java",
         "src/main/java/com/thealgorithms/datastructures/crdt/PNCounter.java",
         "src/main/java/com/thealgorithms/datastructures/graphs/KahnsAlgorithm.java",
diff --git a/src/main/java/com/thealgorithms/conversions/UnitsConverter.java b/src/main/java/com/thealgorithms/conversions/UnitsConverter.java
@@ -3,6 +3,7 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
+import java.util.NoSuchElementException;
 import java.util.Set;
 import org.apache.commons.lang3.tuple.Pair;
 
@@ -77,7 +78,7 @@ public double convert(final String inputUnit, final String outputUnit, final dou
             throw new IllegalArgumentException("inputUnit must be different from outputUnit.");
         }
         final var conversionKey = Pair.of(inputUnit, outputUnit);
-        return conversions.get(conversionKey).convert(value);
+        return conversions.computeIfAbsent(conversionKey, k -> { throw new NoSuchElementException("No converter for: " + k); }).convert(value);
     }
 
     public Set<String> availableUnits() {
diff --git a/src/test/java/com/thealgorithms/conversions/UnitsConverterTest.java b/src/test/java/com/thealgorithms/conversions/UnitsConverterTest.java
@@ -4,6 +4,7 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import java.util.Map;
+import java.util.NoSuchElementException;
 import org.apache.commons.lang3.tuple.Pair;
 import org.junit.jupiter.api.Test;
 
@@ -15,4 +16,12 @@ void testConvertThrowsForSameUnits() {
         assertThrows(IllegalArgumentException.class, () -> someConverter.convert("A", "A", 20.0));
         assertThrows(IllegalArgumentException.class, () -> someConverter.convert("B", "B", 20.0));
     }
+
+    @Test
+    void testConvertThrowsForUnknownUnits() {
+        final UnitsConverter someConverter = new UnitsConverter(Map.ofEntries(entry(Pair.of("A", "B"), new AffineConverter(10.0, -20.0))));
+        assertThrows(NoSuchElementException.class, () -> someConverter.convert("A", "X", 20.0));
+        assertThrows(NoSuchElementException.class, () -> someConverter.convert("X", "A", 20.0));
+        assertThrows(NoSuchElementException.class, () -> someConverter.convert("X", "Y", 20.0));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`import java.util.HashMap;`
`4`	`4`	`import java.util.HashSet;`
`5`	`5`	`import java.util.Map;`
	`6`	`+import java.util.NoSuchElementException;`
`6`	`7`	`import java.util.Set;`
`7`	`8`	`import org.apache.commons.lang3.tuple.Pair;`
`8`	`9`
`@@ -77,7 +78,7 @@ public double convert(final String inputUnit, final String outputUnit, final dou`
`77`	`78`	`throw new IllegalArgumentException("inputUnit must be different from outputUnit.");`
`78`	`79`	`}`
`79`	`80`	`final var conversionKey = Pair.of(inputUnit, outputUnit);`
`80`		`- return conversions.get(conversionKey).convert(value);`
	`81`	`+ return conversions.computeIfAbsent(conversionKey, k -> { throw new NoSuchElementException("No converter for: " + k); }).convert(value);`
`81`	`82`	`}`
`82`	`83`
`83`	`84`	`public Set<String> availableUnits() {`