style: do not suppress serial

vil02 · vil02 · commit 7247fbd156a2 · 2024-05-19T22:51:53.000+02:00
diff --git a/pom.xml b/pom.xml
@@ -79,7 +79,6 @@
                         <arg>-Xlint:all</arg>
                         <arg>-Xlint:-auxiliaryclass</arg>
                         <arg>-Xlint:-rawtypes</arg>
-                        <arg>-Xlint:-serial</arg>
                         <arg>-Xlint:-try</arg>
                         <arg>-Xlint:-unchecked</arg>
                         <arg>-Xlint:-lossy-conversions</arg>
diff --git a/src/main/java/com/thealgorithms/sorts/TopologicalSort.java b/src/main/java/com/thealgorithms/sorts/TopologicalSort.java
@@ -73,13 +73,6 @@ public void addEdge(String label, String... next) {
         }
     }
 
-    static class BackEdgeException extends RuntimeException {
-
-        BackEdgeException(String backEdge) {
-            super("This graph contains a cycle. No linear ordering is possible. " + backEdge);
-        }
-    }
-
     /*
      * Depth First Search
      *
@@ -131,7 +124,7 @@ private static String sort(Graph graph, Vertex u, LinkedList<String> list) {
                  *
                  * In many cases, we will not know u.f, but v.color denotes the type of edge
                  * */
-                throw new BackEdgeException("Back edge: " + u.label + " -> " + label);
+                throw new RuntimeException("This graph contains a cycle. No linear ordering is possible. Back edge: " + u.label + " -> " + label);
             }
         });
         u.color = Color.BLACK;
diff --git a/src/test/java/com/thealgorithms/sorts/TopologicalSortTest.java b/src/test/java/com/thealgorithms/sorts/TopologicalSortTest.java
@@ -3,8 +3,6 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertIterableEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
-
-import com.thealgorithms.sorts.TopologicalSort.BackEdgeException;
 import com.thealgorithms.sorts.TopologicalSort.Graph;
 import java.util.LinkedList;
 import org.junit.jupiter.api.Test;
@@ -55,7 +53,7 @@ public void failureTest() {
         graph.addEdge("6", "2");
         graph.addEdge("7", "");
         graph.addEdge("8", "");
-        Exception exception = assertThrows(BackEdgeException.class, () -> TopologicalSort.sort(graph));
+        Exception exception = assertThrows(RuntimeException.class, () -> TopologicalSort.sort(graph));
         String expected = "This graph contains a cycle. No linear ordering is possible. "
             + "Back edge: 6 -> 2";
         assertEquals(exception.getMessage(), expected);

Original file line number	Diff line number	Diff line change
`@@ -73,13 +73,6 @@ public void addEdge(String label, String... next) {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`- static class BackEdgeException extends RuntimeException {`
`77`		`-`
`78`		`- BackEdgeException(String backEdge) {`
`79`		`- super("This graph contains a cycle. No linear ordering is possible. " + backEdge);`
`80`		`- }`
`81`		`- }`
`82`		`-`
`83`	`76`	`/*`
`84`	`77`	`* Depth First Search`
`85`	`78`	`*`
`@@ -131,7 +124,7 @@ private static String sort(Graph graph, Vertex u, LinkedList<String> list) {`
`131`	`124`	`*`
`132`	`125`	`* In many cases, we will not know u.f, but v.color denotes the type of edge`
`133`	`126`	`* */`
`134`		`- throw new BackEdgeException("Back edge: " + u.label + " -> " + label);`
	`127`	`+ throw new RuntimeException("This graph contains a cycle. No linear ordering is possible. Back edge: " + u.label + " -> " + label);`
`135`	`128`	`}`
`136`	`129`	`});`
`137`	`130`	`u.color = Color.BLACK;`