style: include MAC_MANUAL_ARRAY_COPY (#5199)

vil02 · web-flow · commit 440f3ce18b4b · 2024-06-04T21:02:38.000Z
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
@@ -138,9 +138,6 @@
     <Match>
         <Bug pattern="USBR_UNNECESSARY_STORE_BEFORE_RETURN" />
     </Match>
-    <Match>
-        <Bug pattern="MAC_MANUAL_ARRAY_COPY" />
-    </Match>
     <Match>
         <Bug pattern="SPP_USE_ISEMPTY" />
     </Match>
diff --git a/src/main/java/com/thealgorithms/others/BFPRT.java b/src/main/java/com/thealgorithms/others/BFPRT.java
@@ -34,9 +34,7 @@ public static int getMinKthByBFPRT(int[] arr, int k) {
 
     public static int[] copyArray(int[] arr) {
         int[] copyArr = new int[arr.length];
-        for (int i = 0; i < arr.length; i++) {
-            copyArr[i] = arr[i];
-        }
+        System.arraycopy(arr, 0, copyArr, 0, arr.length);
         return copyArr;
     }
 
diff --git a/src/main/java/com/thealgorithms/others/BankersAlgorithm.java b/src/main/java/com/thealgorithms/others/BankersAlgorithm.java
@@ -60,10 +60,7 @@ static boolean checkSafeSystem(int[] processes, int[] availableArray, int[][] ma
         int[] safeSequenceArray = new int[totalProcess];
 
         int[] workArray = new int[totalResources];
-
-        for (int i = 0; i < totalResources; i++) {
-            workArray[i] = availableArray[i];
-        }
+        System.arraycopy(availableArray, 0, workArray, 0, totalResources);
 
         int count = 0;
 
diff --git a/src/main/java/com/thealgorithms/others/ReturnSubsequence.java b/src/main/java/com/thealgorithms/others/ReturnSubsequence.java
@@ -34,10 +34,8 @@ private static String[] returnSubsequence(String givenString) {
         // position=1
 
         String[] ans = new String[2 * smallAns.length]; // Our answer will be an array off string of size=2*smallAns
-        int i = 0;
-        for (; i < smallAns.length; i++) {
-            ans[i] = smallAns[i]; // Copying all the strings present in smallAns to ans string array
-        }
+        System.arraycopy(smallAns, 0, ans, 0, smallAns.length);
+
         for (int k = 0; k < smallAns.length; k++) {
             ans[k + smallAns.length] = givenString.charAt(0) + smallAns[k]; // Insert character at index=0 of the given
                                                                             // substring in front of every string
diff --git a/src/main/java/com/thealgorithms/sorts/RadixSort.java b/src/main/java/com/thealgorithms/sorts/RadixSort.java
@@ -35,9 +35,7 @@ private static void countSort(int[] arr, int n, int exp) {
             count[(arr[i] / exp) % 10]--;
         }
 
-        for (i = 0; i < n; i++) {
-            arr[i] = output[i];
-        }
+        System.arraycopy(output, 0, arr, 0, n);
     }
 
     private static void radixsort(int[] arr, int n) {

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,7 @@ public static int getMinKthByBFPRT(int[] arr, int k) {`
`34`	`34`
`35`	`35`	`public static int[] copyArray(int[] arr) {`
`36`	`36`	`int[] copyArr = new int[arr.length];`
`37`		`- for (int i = 0; i < arr.length; i++) {`
`38`		`- copyArr[i] = arr[i];`
`39`		`- }`
	`37`	`+ System.arraycopy(arr, 0, copyArr, 0, arr.length);`
`40`	`38`	`return copyArr;`
`41`	`39`	`}`
`42`	`40`
Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,7 @@ private static void countSort(int[] arr, int n, int exp) {`
`35`	`35`	`count[(arr[i] / exp) % 10]--;`
`36`	`36`	`}`
`37`	`37`
`38`		`- for (i = 0; i < n; i++) {`
`39`		`- arr[i] = output[i];`
`40`		`- }`
	`38`	`+ System.arraycopy(output, 0, arr, 0, n);`
`41`	`39`	`}`
`42`	`40`
`43`	`41`	`private static void radixsort(int[] arr, int n) {`