style: include ENMI_EQUALS_ON_ENUM (#5189)

vil02 · web-flow · commit 2cda9446434d · 2024-05-28T19:03:52.000Z
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
@@ -222,9 +222,6 @@
     <Match>
         <Bug pattern="FCBL_FIELD_COULD_BE_LOCAL" />
     </Match>
-    <Match>
-        <Bug pattern="ENMI_EQUALS_ON_ENUM" />
-    </Match>
     <Match>
         <Bug pattern="IMC_IMMATURE_CLASS_VAR_NAME" />
     </Match>
diff --git a/src/main/java/com/thealgorithms/datastructures/crdt/LWWElementSet.java b/src/main/java/com/thealgorithms/datastructures/crdt/LWWElementSet.java
@@ -124,14 +124,14 @@ public void merge(LWWElementSet other) {
      * @return True if the first element's timestamp is greater or the bias is ADDS and timestamps are equal.
      */
     public boolean compareTimestamps(Element e, Element other) {
-        if (!e.bias.equals(other.bias)) {
+        if (e.bias != other.bias) {
             throw new IllegalArgumentException("Invalid bias value");
         }
         Bias bias = e.bias;
         int timestampComparison = Integer.compare(e.timestamp, other.timestamp);
 
         if (timestampComparison == 0) {
-            return !bias.equals(Bias.ADDS);
+            return bias != Bias.ADDS;
         }
         return timestampComparison < 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -124,14 +124,14 @@ public void merge(LWWElementSet other) {`
`124`	`124`	`* @return True if the first element's timestamp is greater or the bias is ADDS and timestamps are equal.`
`125`	`125`	`*/`
`126`	`126`	`public boolean compareTimestamps(Element e, Element other) {`
`127`		`- if (!e.bias.equals(other.bias)) {`
	`127`	`+ if (e.bias != other.bias) {`
`128`	`128`	`throw new IllegalArgumentException("Invalid bias value");`
`129`	`129`	`}`
`130`	`130`	`Bias bias = e.bias;`
`131`	`131`	`int timestampComparison = Integer.compare(e.timestamp, other.timestamp);`
`132`	`132`
`133`	`133`	`if (timestampComparison == 0) {`
`134`		`- return !bias.equals(Bias.ADDS);`
	`134`	`+ return bias != Bias.ADDS;`
`135`	`135`	`}`
`136`	`136`	`return timestampComparison < 0;`
`137`	`137`	`}`