ref: refactor implementation

sozelfist · sozelfist · commit 0b18babd1a27 · 2024-06-05T11:49:11.000+07:00
- Make TreeTraversal interface implementations final
- Update tests
diff --git a/src/main/java/com/thealgorithms/datastructures/trees/SplayTree.java b/src/main/java/com/thealgorithms/datastructures/trees/SplayTree.java
@@ -290,15 +290,7 @@ public void traverse(Node root, List<Integer> result) {
         }
     }
 
-    public static TreeTraversal getInOrderTraversal() {
-        return new InOrderTraversal();
-    }
-
-    public static TreeTraversal getPreOrderTraversal() {
-        return new PreOrderTraversal();
-    }
-
-    public static TreeTraversal getPostOrderTraversal() {
-        return new PostOrderTraversal();
-    }
+    public static final TreeTraversal PRE_ORDER = new PreOrderTraversal();
+    public static final TreeTraversal IN_ORDER = new InOrderTraversal();
+    public static final TreeTraversal POST_ORDER = new PostOrderTraversal();
 }
diff --git a/src/test/java/com/thealgorithms/datastructures/trees/SplayTreeTest.java b/src/test/java/com/thealgorithms/datastructures/trees/SplayTreeTest.java
@@ -74,12 +74,12 @@ public void testSearchInEmptyTree(int value) {
     }
 
     private static Stream<Object[]> traversalStrategies() {
-        return Stream.of(new Object[] {SplayTree.getInOrderTraversal(), Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18)}, new Object[] {SplayTree.getPreOrderTraversal(), Arrays.asList(18, 17, 16, 15, 13, 11, 9, 8, 7, 3, 2, 1, 5, 4, 6, 10, 12)},
-            new Object[] {SplayTree.getPostOrderTraversal(), Arrays.asList(1, 2, 4, 6, 5, 3, 7, 8, 10, 9, 12, 11, 13, 15, 16, 17, 18)});
+        return Stream.of(new Object[] {SplayTree.IN_ORDER, Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18)}, new Object[] {SplayTree.PRE_ORDER, Arrays.asList(18, 17, 16, 15, 13, 11, 9, 8, 7, 3, 2, 1, 5, 4, 6, 10, 12)},
+            new Object[] {SplayTree.POST_ORDER, Arrays.asList(1, 2, 4, 6, 5, 3, 7, 8, 10, 9, 12, 11, 13, 15, 16, 17, 18)});
     }
 
     private static Stream<Integer> valuesToTest() {
-        return Stream.of(1, 5, 10, 17, 8, 13, 6);
+        return Stream.of(1, 5, 10, 17, 8, 13, 6, 17, 4, 11, 9, 2, 18, 3, 16, 7, 12);
     }
 
     private static Stream<Integer> nonExistentValues() {

Original file line number	Diff line number	Diff line change
`@@ -290,15 +290,7 @@ public void traverse(Node root, List<Integer> result) {`
`290`	`290`	`}`
`291`	`291`	`}`
`292`	`292`
`293`		`- public static TreeTraversal getInOrderTraversal() {`
`294`		`- return new InOrderTraversal();`
`295`		`- }`
`296`		`-`
`297`		`- public static TreeTraversal getPreOrderTraversal() {`
`298`		`- return new PreOrderTraversal();`
`299`		`- }`
`300`		`-`
`301`		`- public static TreeTraversal getPostOrderTraversal() {`
`302`		`- return new PostOrderTraversal();`
`303`		`- }`
	`293`	`+ public static final TreeTraversal PRE_ORDER = new PreOrderTraversal();`
	`294`	`+ public static final TreeTraversal IN_ORDER = new InOrderTraversal();`
	`295`	`+ public static final TreeTraversal POST_ORDER = new PostOrderTraversal();`
`304`	`296`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,12 +74,12 @@ public void testSearchInEmptyTree(int value) {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`private static Stream<Object[]> traversalStrategies() {`
`77`		`- return Stream.of(new Object[] {SplayTree.getInOrderTraversal(), Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18)}, new Object[] {SplayTree.getPreOrderTraversal(), Arrays.asList(18, 17, 16, 15, 13, 11, 9, 8, 7, 3, 2, 1, 5, 4, 6, 10, 12)},`
`78`		`- new Object[] {SplayTree.getPostOrderTraversal(), Arrays.asList(1, 2, 4, 6, 5, 3, 7, 8, 10, 9, 12, 11, 13, 15, 16, 17, 18)});`
	`77`	`+ return Stream.of(new Object[] {SplayTree.IN_ORDER, Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 15, 16, 17, 18)}, new Object[] {SplayTree.PRE_ORDER, Arrays.asList(18, 17, 16, 15, 13, 11, 9, 8, 7, 3, 2, 1, 5, 4, 6, 10, 12)},`
	`78`	`+ new Object[] {SplayTree.POST_ORDER, Arrays.asList(1, 2, 4, 6, 5, 3, 7, 8, 10, 9, 12, 11, 13, 15, 16, 17, 18)});`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`private static Stream<Integer> valuesToTest() {`
`82`		`- return Stream.of(1, 5, 10, 17, 8, 13, 6);`
	`82`	`+ return Stream.of(1, 5, 10, 17, 8, 13, 6, 17, 4, 11, 9, 2, 18, 3, 16, 7, 12);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`private static Stream<Integer> nonExistentValues() {`