Skip to content

Commit 0be1f03

Browse files
committed
add python_requires; clean up a bit
1 parent 3673965 commit 0be1f03

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

setup.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,10 @@ def read(*relpath, **kwargs): # https://blog.ionelmc.ro/2014/05/25/python-packa
111111
# See
112112
# http://setuptools.readthedocs.io/en/latest/setuptools.html
113113
#
114-
setup_requires=[],
115-
install_requires=[],
114+
python_requires=">=3.4,<3.8",
115+
install_requires=[], # MacroPy is optional for us, so we can't really put "macropy3" here even though we recommend it.
116+
# setup_requires=[], # TODO: Using setup_requires is discouraged in favor of https://www.python.org/dev/peps/pep-0518/
117+
# test_requires=["macropy3"], # TODO: not very useful, because only "python3 setup.py test" installs these, and we don't use that.
116118
provides=["unpythonic"],
117119

118120
# keywords for PyPI (in case you upload your project)

0 commit comments

Comments
 (0)