From 66b851f71edd42a426e7f41d25ecbc2fea0fb7b0 Mon Sep 17 00:00:00 2001 From: Lexa Whitehurst Date: Thu, 30 May 2024 13:49:28 -0700 Subject: [PATCH] Add fallback to ide redirect when browser detection fails --- .../apiweb/templates/partial_launcher_detailed.hbs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/api_server/modules/apiweb/templates/partial_launcher_detailed.hbs b/api_server/modules/apiweb/templates/partial_launcher_detailed.hbs index 1a4f10834..ff5e5da8a 100644 --- a/api_server/modules/apiweb/templates/partial_launcher_detailed.hbs +++ b/api_server/modules/apiweb/templates/partial_launcher_detailed.hbs @@ -262,6 +262,10 @@ successCb && successCb(); } + function unsupportedCallback() { + unsupportedCb && unsupportedCb(); + } + if (navigator.msLaunchUri) { //for IE and Edge in Win 8 and Win 10 openUriWithMsLaunchUri(uri, failCb, successCb); } else { @@ -276,8 +280,9 @@ } else if (browser.isSafari) { openUriWithHiddenFrame(uri, failCallback, successCallback); } else { - unsupportedCb(); - //not supported, implement please + unsupportedCallback(); + // this works for most common browsers, so we try it if detection fails + openUriWithTimeoutHack(uri, failCallback, successCallback); } } }