From 1ee5a886b49fefe65413ef664bb195d2517fef2e Mon Sep 17 00:00:00 2001
From: "yanqi.zong" <yzong@turo.com>
Date: Wed, 7 May 2025 16:05:53 -0700
Subject: [PATCH] feat: update vite config

---
 packages/ui/package.json   | 10 +++++++---
 packages/ui/vite.config.ts | 10 +++++++++-
 pnpm-lock.yaml             | 12 ++++++------
 3 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/packages/ui/package.json b/packages/ui/package.json
index c03976d..99bc26f 100644
--- a/packages/ui/package.json
+++ b/packages/ui/package.json
@@ -15,10 +15,12 @@
     "prepublishOnly": "pnpm build"
   },
   "dependencies": {
-    "react": "^19.0.0",
-    "react-dom": "^19.0.0",
     "react-icons": "^5.3.0"
   },
+  "peerDependencies": {
+    "react": "^18.0.0 || ^19.0.0",
+    "react-dom": "^18.0.0 || ^19.0.0"
+  },
   "devDependencies": {
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
@@ -37,7 +39,9 @@
     "typescript": "^5.2.2",
     "vite": "^5.2.0",
     "vite-plugin-dts": "^4.5.3",
-    "vitest": "^1.5.0"
+    "vitest": "^1.5.0",
+    "react": "^19.0.0",
+    "react-dom": "^19.0.0"
   },
   "publishConfig": {
     "access": "public"
diff --git a/packages/ui/vite.config.ts b/packages/ui/vite.config.ts
index 49d297e..e742180 100644
--- a/packages/ui/vite.config.ts
+++ b/packages/ui/vite.config.ts
@@ -18,16 +18,24 @@ export default defineConfig({
       entry: resolve(__dirname, 'src/index.ts'),
       name: 'TanstackDevComponents',
       fileName: 'index',
+      formats: ['es'],
     },
     rollupOptions: {
-      external: ['react', 'react-dom', 'react/jsx-runtime'],
+      external: ['react', 'react-dom', 'react/jsx-runtime', 'react-icons'],
       output: {
         globals: {
           react: 'React',
           'react-dom': 'ReactDOM',
           'react/jsx-runtime': 'jsxRuntime',
+          'react-icons': 'ReactIcons',
         },
       },
     },
+    // Ensure the bundle doesn't include React
+    commonjsOptions: {
+      esmExternals: ['react', 'react-dom'],
+    },
+    sourcemap: true,
+    minify: false,
   },
 });
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index e0cf906..5fcc608 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -90,12 +90,6 @@ importers:
 
   packages/ui:
     dependencies:
-      react:
-        specifier: ^19.0.0
-        version: 19.1.0
-      react-dom:
-        specifier: ^19.0.0
-        version: 19.1.0(react@19.1.0)
       react-icons:
         specifier: ^5.3.0
         version: 5.5.0(react@19.1.0)
@@ -139,6 +133,12 @@ importers:
       eslint-plugin-react-refresh:
         specifier: ^0.4.6
         version: 0.4.6(eslint@8.57.0)
+      react:
+        specifier: ^19.0.0
+        version: 19.1.0
+      react-dom:
+        specifier: ^19.0.0
+        version: 19.1.0(react@19.1.0)
       semantic-release:
         specifier: ^24.2.3
         version: 24.2.3(typescript@5.4.5)