apply code review feedback

studix · studix · commit a64ec95c8d49 · 2021-06-02T21:04:25.000+02:00
Signed-off-by: Marco Studer &lt;marco.studer@bison-group.com&gt;
diff --git a/ArchUnitNETTests/Domain/PlantUml/TestDiagram.cs b/ArchUnitNETTests/Domain/PlantUml/TestDiagram.cs
@@ -22,9 +22,9 @@ public static TestDiagram In(string path)
             return new TestDiagram(path);
         }
 
-        public ComponentCreator Component(string componentName)
+        public ComponentBuilder Component(string componentName)
         {
-            return new ComponentCreator(componentName, this);
+            return new ComponentBuilder(componentName, this);
         }
 
         public DependencyFromCreator DependencyFrom(string origin)
@@ -37,7 +37,7 @@ public DependencyToCreator DependencyTo(string target)
             return new DependencyToCreator(target, this);
         }
 
-        private TestDiagram AddComponent(ComponentCreator creator)
+        private TestDiagram AddComponent(ComponentBuilder creator)
         {
             string stereotypes = string.Join(" ", creator.Stereotypes.Select(input => "<<" + input + ">>"));
             string line = string.Format("[{0}] {1}", creator.ComponentName, stereotypes);
@@ -75,11 +75,11 @@ private StreamWriter CreateTempFile(string path)
             return File.CreateText(path);
         }
 
-        public class ComponentCreator
+        public class ComponentBuilder
         {
             private readonly TestDiagram _testDiagram;
 
-            public ComponentCreator(string componentName, TestDiagram testDiagram)
+            public ComponentBuilder(string componentName, TestDiagram testDiagram)
             {
                 ComponentName = componentName;
                 _testDiagram = testDiagram;
@@ -90,7 +90,7 @@ public ComponentCreator(string componentName, TestDiagram testDiagram)
 
             public List<string> Stereotypes { get; } = new List<string>();
 
-            public ComponentCreator WithAlias(string alias)
+            public ComponentBuilder WithAlias(string alias)
             {
                 Alias = alias;
                 return this;
diff --git a/ExampleTest/Resources/shopping_example.puml b/ExampleTest/Resources/shopping_example.puml
@@ -33,7 +33,7 @@ catalog --> [Orders]
 import -left-> catalog : parse products
 import --> xml
 import --> [Customers]
-note top on link #lightgreen: is responsible for translating XML to java classes
+note top on link #lightgreen: is responsible for translating XML to csharp classes
 
 
 @enduml

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,9 @@ public static TestDiagram In(string path)`
`22`	`22`	`return new TestDiagram(path);`
`23`	`23`	`}`
`24`	`24`
`25`		`- public ComponentCreator Component(string componentName)`
	`25`	`+ public ComponentBuilder Component(string componentName)`
`26`	`26`	`{`
`27`		`- return new ComponentCreator(componentName, this);`
	`27`	`+ return new ComponentBuilder(componentName, this);`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`public DependencyFromCreator DependencyFrom(string origin)`
`@@ -37,7 +37,7 @@ public DependencyToCreator DependencyTo(string target)`
`37`	`37`	`return new DependencyToCreator(target, this);`
`38`	`38`	`}`
`39`	`39`
`40`		`- private TestDiagram AddComponent(ComponentCreator creator)`
	`40`	`+ private TestDiagram AddComponent(ComponentBuilder creator)`
`41`	`41`	`{`
`42`	`42`	`string stereotypes = string.Join(" ", creator.Stereotypes.Select(input => "<<" + input + ">>"));`
`43`	`43`	`string line = string.Format("[{0}] {1}", creator.ComponentName, stereotypes);`
`@@ -75,11 +75,11 @@ private StreamWriter CreateTempFile(string path)`
`75`	`75`	`return File.CreateText(path);`
`76`	`76`	`}`
`77`	`77`
`78`		`- public class ComponentCreator`
	`78`	`+ public class ComponentBuilder`
`79`	`79`	`{`
`80`	`80`	`private readonly TestDiagram _testDiagram;`
`81`	`81`
`82`		`- public ComponentCreator(string componentName, TestDiagram testDiagram)`
	`82`	`+ public ComponentBuilder(string componentName, TestDiagram testDiagram)`
`83`	`83`	`{`
`84`	`84`	`ComponentName = componentName;`
`85`	`85`	`_testDiagram = testDiagram;`
`@@ -90,7 +90,7 @@ public ComponentCreator(string componentName, TestDiagram testDiagram)`
`90`	`90`
`91`	`91`	`public List<string> Stereotypes { get; } = new List<string>();`
`92`	`92`
`93`		`- public ComponentCreator WithAlias(string alias)`
	`93`	`+ public ComponentBuilder WithAlias(string alias)`
`94`	`94`	`{`
`95`	`95`	`Alias = alias;`
`96`	`96`	`return this;`