Quiet tracers

64json · 64json · commit 6cf9434f6d59 · 2019-01-18T11:52:58.000-05:00
diff --git a/src/backend/common/util.js b/src/backend/common/util.js
@@ -4,8 +4,8 @@ import path from 'path';
 import fs from 'fs-extra';
 import removeMarkdown from 'remove-markdown';
 
-const execute = (command, cwd, { stdout = process.stdout, stderr = process.stderr } = {}) => new Promise((resolve, reject) => {
-  const child = child_process.exec(command, { cwd }, (error, stdout, stderr) => {
+const execute = (command, { stdout = process.stdout, stderr = process.stderr, ...options } = {}) => new Promise((resolve, reject) => {
+  const child = child_process.exec(command, options, (error, stdout, stderr) => {
     if (error) return reject(error.code ? new Error(stderr) : error);
     resolve(stdout);
   });
diff --git a/src/backend/controllers/algorithms.js b/src/backend/controllers/algorithms.js
@@ -9,8 +9,8 @@ const router = express.Router();
 
 const downloadCategories = () => (
   fs.pathExistsSync(hierarchy.path) ?
-    execute(`git fetch && git reset --hard origin/master`, hierarchy.path) :
-    execute(`git clone https://github.com/algorithm-visualizer/algorithms.git ${hierarchy.path}`, __dirname)
+    execute(`git fetch && git reset --hard origin/master`, { cwd: hierarchy.path }) :
+    execute(`git clone https://github.com/algorithm-visualizer/algorithms.git ${hierarchy.path}`)
 ).then(() => hierarchy.refresh());
 
 downloadCategories().catch(console.error);
diff --git a/src/backend/controllers/tracers.js b/src/backend/controllers/tracers.js
@@ -32,7 +32,7 @@ const trace = lang => (req, res, next) => {
         `-m=${memoryLimit}m`,
         '-e ALGORITHM_VISUALIZER=1',
         builder.imageName,
-      ].join(' ')).catch(error => {
+      ].join(' '), { stdout: null, stderr: null }).catch(error => {
         if (killed) throw new Error('Time Limit Exceeded');
         throw error;
       }).finally(() => clearTimeout(timer));
diff --git a/src/backend/models/Hierarchy.js b/src/backend/models/Hierarchy.js
@@ -40,19 +40,20 @@ class Hierarchy {
 
   cacheContributors(files, commitAuthors) {
     return Promise.each(files, file => {
-      return execute(`git --no-pager log --follow --no-merges --format="%H" "${file.path}"`, this.path, { stdout: null })
-        .then(stdout => {
-          const output = stdout.toString().replace(/\n$/, '');
-          const shas = output.split('\n').reverse();
-          const contributors = [];
-          for (const sha of shas) {
-            const author = commitAuthors[sha];
-            if (author && !contributors.find(contributor => contributor.login === author.login)) {
-              contributors.push(author);
-            }
+      return execute(`git --no-pager log --follow --no-merges --format="%H" "${file.path}"`, {
+        cwd: this.path, stdout: null,
+      }).then(stdout => {
+        const output = stdout.toString().replace(/\n$/, '');
+        const shas = output.split('\n').reverse();
+        const contributors = [];
+        for (const sha of shas) {
+          const author = commitAuthors[sha];
+          if (author && !contributors.find(contributor => contributor.login === author.login)) {
+            contributors.push(author);
           }
-          file.contributors = contributors;
-        });
+        }
+        file.contributors = contributors;
+      });
     });
   }
 
diff --git a/src/backend/tracers/ImageBuilder.js b/src/backend/tracers/ImageBuilder.js
@@ -12,7 +12,7 @@ class ImageBuilder {
 
   build(release) {
     const { tag_name } = release;
-    return execute(`docker build -t ${this.imageName} . --build-arg tag_name=${tag_name}`, this.directory);
+    return execute(`docker build -t ${this.imageName} . --build-arg tag_name=${tag_name}`, { cwd: this.directory });
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ class ImageBuilder {`
`12`	`12`
`13`	`13`	`build(release) {`
`14`	`14`	`const { tag_name } = release;`
`15`		- return execute(`docker build -t ${this.imageName} . --build-arg tag_name=${tag_name}`, this.directory);
	`15`	+ return execute(`docker build -t ${this.imageName} . --build-arg tag_name=${tag_name}`, { cwd: this.directory });
`16`	`16`	`}`
`17`	`17`	`}`
`18`	`18`