Cleanup various warnings (#170)

billoneil · web-flow · commit 8e29b931f0e5 · 2020-12-19T14:48:48.000-05:00
diff --git a/stubbornjava-common/src/main/java/com/stubbornjava/common/DeterministicObjectMapper.java b/stubbornjava-common/src/main/java/com/stubbornjava/common/DeterministicObjectMapper.java
@@ -53,7 +53,8 @@ public static ObjectMapper create(ObjectMapper original, CustomComparators custo
      * before we added our module to it. If we have a Collection -> Collection converter
      * it delegates to itself and infinite loops until the stack overflows.
      */
-    private static class CustomDelegatingSerializerProvider extends StdDelegatingSerializer
+    @SuppressWarnings("serial")
+	private static class CustomDelegatingSerializerProvider extends StdDelegatingSerializer
     {
         private final SerializerProvider serializerProvider;
 
diff --git a/stubbornjava-common/src/main/java/com/stubbornjava/common/GraphiteHttpSender.java b/stubbornjava-common/src/main/java/com/stubbornjava/common/GraphiteHttpSender.java
@@ -14,8 +14,6 @@
 import okhttp3.OkHttpClient;
 import okhttp3.Request;
 import okhttp3.RequestBody;
-import okhttp3.logging.HttpLoggingInterceptor;
-import okhttp3.logging.HttpLoggingInterceptor.Level;
 
 // {{start:sender}}
 /**
@@ -26,7 +24,8 @@
  *
  */
 class GraphiteHttpSender implements GraphiteSender {
-    private static final Logger log = LoggerFactory.getLogger(GraphiteHttpSender.class);
+    @SuppressWarnings("unused")
+	private static final Logger log = LoggerFactory.getLogger(GraphiteHttpSender.class);
 
     private final OkHttpClient client;
     private final String host;
@@ -58,9 +57,9 @@ public void send(String name, String value, long timestamp) throws IOException {
     public void flush() throws IOException {
         Request request = new Request.Builder()
                 .url(host + "/metrics")
-                .post(RequestBody.create(MediaType.parse("application/json"), Json.serializer().toByteArray(metrics)))
+                .post(RequestBody.Companion.create(Json.serializer().toByteArray(metrics), MediaType.Companion.parse("application/json")))
                 .build();
-        String response = Retry.retryUntilSuccessfulWithBackoff(() -> client.newCall(request).execute());
+        Retry.retryUntilSuccessfulWithBackoff(() -> client.newCall(request).execute());
         metrics.clear();
     }
 
@@ -76,14 +75,6 @@ public int getFailures() {
         return 0;
     }
 
-    private static final HttpLoggingInterceptor getLogger(Level level) {
-        HttpLoggingInterceptor loggingInterceptor = new HttpLoggingInterceptor((msg) -> {
-            log.debug(msg);
-        });
-        loggingInterceptor.setLevel(level);
-        return loggingInterceptor;
-    }
-
     private static final class GraphiteMetric {
         private final String name;
         private final int interval;
@@ -100,16 +91,20 @@ public GraphiteMetric(@JsonProperty("name") String name,
             this.time = time;
         }
 
-        public String getName() {
+        @SuppressWarnings("unused")
+		public String getName() {
             return name;
         }
-        public int getInterval() {
+        @SuppressWarnings("unused")
+		public int getInterval() {
             return interval;
         }
-        public double getValue() {
+        @SuppressWarnings("unused")
+		public double getValue() {
             return value;
         }
-        public long getTime() {
+        @SuppressWarnings("unused")
+		public long getTime() {
             return time;
         }
     }
diff --git a/stubbornjava-common/src/main/java/com/stubbornjava/common/Http.java b/stubbornjava-common/src/main/java/com/stubbornjava/common/Http.java
@@ -15,7 +15,8 @@
 import okhttp3.Response;
 
 public class Http {
-    private static final Logger log = LoggerFactory.getLogger(Http.class);
+    @SuppressWarnings("unused")
+	private static final Logger log = LoggerFactory.getLogger(Http.class);
 
     // {{start:get}}
     public static Response get(OkHttpClient client, String url) {
diff --git a/stubbornjava-common/src/main/java/com/stubbornjava/common/HttpClient.java b/stubbornjava-common/src/main/java/com/stubbornjava/common/HttpClient.java
@@ -42,9 +42,9 @@ private HttpClient() {
         });
     static {
         if (log.isDebugEnabled()) {
-            loggingInterceptor.setLevel(Level.BASIC);
+            loggingInterceptor.level(Level.BASIC);
         } else if (log.isTraceEnabled()) {
-            loggingInterceptor.setLevel(Level.BODY);
+            loggingInterceptor.level(Level.BODY);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,8 @@ public static ObjectMapper create(ObjectMapper original, CustomComparators custo`
`53`	`53`	`* before we added our module to it. If we have a Collection -> Collection converter`
`54`	`54`	`* it delegates to itself and infinite loops until the stack overflows.`
`55`	`55`	`*/`
`56`		`- private static class CustomDelegatingSerializerProvider extends StdDelegatingSerializer`
	`56`	`+ @SuppressWarnings("serial")`
	`57`	`+ private static class CustomDelegatingSerializerProvider extends StdDelegatingSerializer`
`57`	`58`	`{`
`58`	`59`	`private final SerializerProvider serializerProvider;`
`59`	`60`
Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,9 @@ private HttpClient() {`
`42`	`42`	`});`
`43`	`43`	`static {`
`44`	`44`	`if (log.isDebugEnabled()) {`
`45`		`- loggingInterceptor.setLevel(Level.BASIC);`
	`45`	`+ loggingInterceptor.level(Level.BASIC);`
`46`	`46`	`} else if (log.isTraceEnabled()) {`
`47`		`- loggingInterceptor.setLevel(Level.BODY);`
	`47`	`+ loggingInterceptor.level(Level.BODY);`
`48`	`48`	`}`
`49`	`49`	`}`
`50`	`50`