Skip to content

Commit 3b6c555

Browse files
committed
Fix annotations
1 parent 4cd9552 commit 3b6c555

File tree

1 file changed

+19
-6
lines changed
  • stubbornjava-examples/src/main/java/com/stubbornjava/examples/common

1 file changed

+19
-6
lines changed

stubbornjava-examples/src/main/java/com/stubbornjava/examples/common/EnumLookup.java

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public void setColor(CardColor color) {
6969
* Please don't do this! It is inefficient and it's
7070
* not very hard to use Guava or a static Map as an index.
7171
*/
72-
public static CardSuit crappyFindByName(String name) {
72+
public static CardSuit iterationFindByName(String name) {
7373
for (CardSuit suit : CardSuit.values()) {
7474
if (name.equals(suit.name())) {
7575
return suit;
@@ -88,12 +88,13 @@ public static CardSuit trycatchValueOf(String name) {
8888
try {
8989
return CardSuit.valueOf(name);
9090
} catch (Exception ex) {
91+
log.warn("Exception Thrown", ex);
9192
return null;
9293
}
9394
}
9495
// {{end:trycatch}}
9596

96-
// {{start:map}}
97+
// {{start:mapindex}}
9798
private static final Map<String, CardSuit> nameIndex =
9899
Maps.newHashMapWithExpectedSize(CardSuit.values().length);
99100
static {
@@ -104,7 +105,7 @@ public static CardSuit trycatchValueOf(String name) {
104105
public static CardSuit lookupByName(String name) {
105106
return nameIndex.get(name);
106107
}
107-
// {{end:map}}
108+
// {{end:mapindex}}
108109

109110
// {{start:guava}}
110111
public static CardSuit getIfPresent(String name) {
@@ -134,7 +135,6 @@ public static CardSuit lookupByDisplayNameUtil(String name) {
134135
// {{end:mapDisplayNameUtil}}
135136
}
136137

137-
// {{start:main}}
138138
public static void main(String[] args) {
139139
List<String> names = Arrays.stream(CardSuit.values())
140140
.map(e -> e.name())
@@ -147,6 +147,7 @@ public static void main(String[] args) {
147147
displayNames.add("Missing");
148148

149149

150+
// {{start:valueof-out}}
150151
log.debug("Running valueOf");
151152
for (String name : names) {
152153
try {
@@ -155,36 +156,48 @@ public static void main(String[] args) {
155156
log.warn("Exception Thrown", ex);
156157
}
157158
}
159+
// {{end:valueof-out}}
158160

161+
// {{start:iteration-out}}
159162
log.debug("Running crappyFindByName");
160163
for (String name : names) {
161-
log.debug("looking up {} found {}", name, Json.serializer().toString(CardSuit.crappyFindByName(name)));
164+
log.debug("looking up {} found {}", name, Json.serializer().toString(CardSuit.iterationFindByName(name)));
162165
}
166+
// {{end:iteration-out}}
163167

168+
// {{start:trycatch-out}}
164169
log.debug("Running trycatchValueOf");
165170
for (String name : names) {
166171
log.debug("looking up {} found {}", name, Json.serializer().toString(CardSuit.trycatchValueOf(name)));
167172
}
173+
// {{end:trycatch-out}}
168174

175+
// {{start:mapindex-out}}
169176
log.debug("Running lookupByName");
170177
for (String name : names) {
171178
log.debug("looking up {} found {}", name, Json.serializer().toString(CardSuit.lookupByName(name)));
172179
}
180+
// {{end:mapindex-out}}
173181

182+
// {{start:guava-out}}
174183
log.debug("Running Guava getIfPresent");
175184
for (String name : names) {
176185
log.debug("looking up {} found {}", name, Json.serializer().toString(CardSuit.getIfPresent(name)));
177186
}
187+
// {{end:guava-out}}
178188

189+
// {{start:mapDisplayName-out}}
179190
log.debug("Running lookupByDisplayName");
180191
for (String displayName : displayNames) {
181192
log.debug("looking up {} found {}", displayName, Json.serializer().toString(CardSuit.lookupByDisplayName(displayName)));
182193
}
194+
// {{end:mapDisplayName-out}}
183195

196+
// {{start:mapDisplayNameUtil-out}}
184197
log.debug("Running lookupByDisplayNameUtil");
185198
for (String displayName : displayNames) {
186199
log.debug("looking up {} found {}", displayName, Json.serializer().toString(CardSuit.lookupByDisplayNameUtil(displayName)));
187200
}
201+
// {{end:mapDisplayNameUtil-out}}
188202
}
189-
// {{end:main}}
190203
}

0 commit comments

Comments
 (0)