travis,jenkins: Fail build if javac emits warnings

ejona86 · ejona86 · commit 3c03eb79ecb4 · 2016-07-10T12:01:07.000-07:00
diff --git a/.travis.yml b/.travis.yml
@@ -21,6 +21,7 @@ before_install:
   - ln -s "/tmp/protobuf-${PROTOBUF_VERSION}/$(uname -s)-$(uname -p)" /tmp/protobuf
   - mkdir -p $HOME/.gradle
   - echo "checkstyle.ignoreFailures=false" >> $HOME/.gradle/gradle.properties
+  - echo "failOnWarnings=true" >> $HOME/.gradle/gradle.properties
 
 install:
   - ./gradlew assemble generateTestProto
diff --git a/build.gradle b/build.gradle
@@ -32,6 +32,9 @@ subprojects {
     [compileJava, compileTestJava].each() {
         it.options.compilerArgs += ["-Xlint:all", "-Xlint:-options"]
         it.options.encoding = "UTF-8"
+        if (rootProject.hasProperty('failOnWarnings') && rootProject.failOnWarnings.toBoolean()) {
+            it.options.compilerArgs += ["-Werror"]
+        }
     }
 
     compileTestJava {
diff --git a/buildscripts/jenkins-pre.bat b/buildscripts/jenkins-pre.bat
@@ -13,5 +13,6 @@ cd "%WORKSPACE%"
 set ESCWORKSPACE=%WORKSPACE:\=\\%
 
 echo targetArch=x86_32> gradle.properties
+echo failOnWarnings=true>> gradle.properties
 echo vcProtobufLibs=%ESCWORKSPACE%\\grpc-java-helper\\protobuf-3.0.0-beta-3\\cmake\\build\\Release>> gradle.properties
 echo vcProtobufInclude=%ESCWORKSPACE%\\grpc-java-helper\\protobuf-3.0.0-beta-3\\cmake\\build\\include>> gradle.properties

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@ subprojects {`
`32`	`32`	`[compileJava, compileTestJava].each() {`
`33`	`33`	`it.options.compilerArgs += ["-Xlint:all", "-Xlint:-options"]`
`34`	`34`	`it.options.encoding = "UTF-8"`
	`35`	`+ if (rootProject.hasProperty('failOnWarnings') && rootProject.failOnWarnings.toBoolean()) {`
	`36`	`+ it.options.compilerArgs += ["-Werror"]`
	`37`	`+ }`
`35`	`38`	`}`
`36`	`39`
`37`	`40`	`compileTestJava {`