py/objtype: Remove TODO comment about needing to check for property.

dpgeorge · dpgeorge · commit dfeaea144168 · 2018-05-25T10:59:40.000+10:00
Instance members are always treated as values, even if they are properties.
A test is added to show this is the case.
diff --git a/py/objtype.c b/py/objtype.c
@@ -562,7 +562,6 @@ STATIC void mp_obj_instance_load_attr(mp_obj_t self_in, qstr attr, mp_obj_t *des
     mp_map_elem_t *elem = mp_map_lookup(&self->members, MP_OBJ_NEW_QSTR(attr), MP_MAP_LOOKUP);
     if (elem != NULL) {
         // object member, always treated as a value
-        // TODO should we check for properties?
         dest[0] = elem->value;
         return;
     }
diff --git a/tests/basics/builtin_property.py b/tests/basics/builtin_property.py
@@ -105,3 +105,9 @@ class E:
     # not tested for because the other keyword arguments are not accepted
     # q = property(fget=lambda self: 21, doc="Half the truth.")
 print(E().p)
+
+# a property as an instance member should not be delegated to
+class F:
+    def __init__(self):
+        self.prop_member = property()
+print(type(F().prop_member))

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,6 @@ STATIC void mp_obj_instance_load_attr(mp_obj_t self_in, qstr attr, mp_obj_t *des`
`562`	`562`	`mp_map_elem_t *elem = mp_map_lookup(&self->members, MP_OBJ_NEW_QSTR(attr), MP_MAP_LOOKUP);`
`563`	`563`	`if (elem != NULL) {`
`564`	`564`	`// object member, always treated as a value`
`565`		`- // TODO should we check for properties?`
`566`	`565`	`dest[0] = elem->value;`
`567`	`566`	`return;`
`568`	`567`	`}`