py/mpz: Use assert to verify mpz does not have a fixed digit buffer.

dpgeorge · dpgeorge · commit df3e5d2b2f86 · 2016-10-11T13:00:56.000+11:00
diff --git a/py/mpz.c b/py/mpz.c
@@ -734,11 +734,9 @@ STATIC void mpz_need_dig(mpz_t *z, mp_uint_t need) {
     }
 
     if (z->dig == NULL || z->alloc < need) {
-        if (z->fixed_dig) {
-            // cannot reallocate fixed buffers
-            assert(0);
-            return;
-        }
+        // if z has fixed digit buffer there's not much we can do as the caller will
+        // be expecting a buffer with at least "need" bytes (but it shouldn't happen)
+        assert(!z->fixed_dig);
         z->dig = m_renew(mpz_dig_t, z->dig, z->alloc, need);
         z->alloc = need;
     }

Original file line number	Diff line number	Diff line change
`@@ -734,11 +734,9 @@ STATIC void mpz_need_dig(mpz_t *z, mp_uint_t need) {`
`734`	`734`	`}`
`735`	`735`
`736`	`736`	`if (z->dig == NULL \|\| z->alloc < need) {`
`737`		`- if (z->fixed_dig) {`
`738`		`- // cannot reallocate fixed buffers`
`739`		`- assert(0);`
`740`		`- return;`
`741`		`- }`
	`737`	`+ // if z has fixed digit buffer there's not much we can do as the caller will`
	`738`	`+ // be expecting a buffer with at least "need" bytes (but it shouldn't happen)`
	`739`	`+ assert(!z->fixed_dig);`
`742`	`740`	`z->dig = m_renew(mpz_dig_t, z->dig, z->alloc, need);`
`743`	`741`	`z->alloc = need;`
`744`	`742`	`}`