sequence: Fix yet another case of improper sequence comparison.

pfalcon · pfalcon · commit ad3baec12f2d · 2014-05-15T19:09:06.000+03:00
This time, in mp_seq_cmp_bytes(). How many more cases are still lurking?
diff --git a/py/sequence.c b/py/sequence.c
@@ -100,6 +100,10 @@ bool mp_seq_cmp_bytes(int op, const byte *data1, uint len1, const byte *data2, u
     }
     uint min_len = len1 < len2 ? len1 : len2;
     int res = memcmp(data1, data2, min_len);
+    if (op == MP_BINARY_OP_EQUAL) {
+        // If we are checking for equality, here're the answer
+        return res == 0;
+    }
     if (res < 0) {
         return false;
     }
diff --git a/tests/basics/bytes_compare.py b/tests/basics/bytes_compare.py
@@ -49,3 +49,5 @@
 print(b"1" <= b"1/")
 print(b"10" <= b"1")
 print(b"1/" <= b"1")
+
+print(b'o' == b'\n')

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,10 @@ bool mp_seq_cmp_bytes(int op, const byte data1, uint len1, const byte data2, u`
`100`	`100`	`}`
`101`	`101`	`uint min_len = len1 < len2 ? len1 : len2;`
`102`	`102`	`int res = memcmp(data1, data2, min_len);`
	`103`	`+ if (op == MP_BINARY_OP_EQUAL) {`
	`104`	`+ // If we are checking for equality, here're the answer`
	`105`	`+ return res == 0;`
	`106`	`+ }`
`103`	`107`	`if (res < 0) {`
`104`	`108`	`return false;`
`105`	`109`	`}`