Skip to content

Commit 7f744a2

Browse files
jeplerjepler
committed
Supervisor: move most of systick to the supervisor
This code is shared by most parts, except where not all the #ifdefs inside the tick function were present in all ports. This mostly would have broken gamepad tick support on non-samd ports. The "ms32" and "ms64" variants of the tick functions are introduced because there is no 64-bit atomic read. Disabling interrupts avoids a low probability bug where milliseconds could be off by ~49.5 days once every ~49.5 days (2^32 ms). Avoiding disabling interrupts when only the low 32 bits are needed is a minor optimization. Testing performed: on metro m4 express, USB still works and time.monotonic_ns() still counts up
1 parent 45d1b29 commit 7f744a2

37 files changed

Lines changed: 214 additions & 163 deletions

File tree

‎drivers/wiznet5k/internet/dns/dns.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252

5353
#include <string.h>
5454
#include <stdlib.h>
55-
#include "tick.h"
55+
#include "supervisor/shared/tick.h"
5656

5757
//#include "Ethernet/socket.h"
5858
//#include "Internet/DNS/dns.h"
@@ -125,7 +125,7 @@ uint16_t DNS_MSGID; // DNS message ID
125125

126126

127127
uint32_t HAL_GetTick(void) {
128-
return ticks_ms;
128+
return supervisor_ticks_ms32();
129129
}
130130

131131
uint32_t hal_sys_tick;

‎ports/atmel-samd/background.c‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
#include "audio_dma.h"
2929
#include "tick.h"
3030
#include "supervisor/filesystem.h"
31+
#include "supervisor/shared/tick.h"
3132
#include "supervisor/usb.h"
3233

3334
#include "py/runtime.h"
@@ -71,9 +72,9 @@ void run_background_tasks(void) {
7172
running_background_tasks = false;
7273
assert_heap_ok();
7374

74-
last_finished_tick = ticks_ms;
75+
last_finished_tick = supervisor_ticks_ms64();
7576
}
7677

7778
bool background_tasks_ok(void) {
78-
return ticks_ms - last_finished_tick < 1000;
79+
return supervisor_ticks_ms64() - last_finished_tick < 1000;
7980
}

‎ports/atmel-samd/common-hal/busio/UART.c‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@
3434
#include "py/runtime.h"
3535
#include "py/stream.h"
3636
#include "supervisor/shared/translate.h"
37-
38-
#include "tick.h"
37+
#include "supervisor/shared/tick.h"
3938

4039
#include "hpl_sercom_config.h"
4140
#include "peripheral_clk_config.h"
@@ -272,10 +271,10 @@ size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t
272271
usart_async_get_io_descriptor(usart_desc_p, &io);
273272

274273
size_t total_read = 0;
275-
uint64_t start_ticks = ticks_ms;
274+
uint64_t start_ticks = supervisor_ticks_ms64();
276275

277276
// Busy-wait until timeout or until we've read enough chars.
278-
while (ticks_ms - start_ticks <= self->timeout_ms) {
277+
while (supervisor_ticks_ms64() - start_ticks <= self->timeout_ms) {
279278
// Read as many chars as we can right now, up to len.
280279
size_t num_read = io_read(io, data, len);
281280

@@ -289,7 +288,7 @@ size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t
289288
}
290289
if (num_read > 0) {
291290
// Reset the timeout on every character read.
292-
start_ticks = ticks_ms;
291+
start_ticks = supervisor_ticks_ms64();
293292
}
294293
RUN_BACKGROUND_TASKS;
295294
// Allow user to break out of a timeout with a KeyboardInterrupt.
@@ -330,9 +329,9 @@ size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data,
330329

331330
// Wait until write is complete or timeout.
332331
bool done = false;
333-
uint64_t start_ticks = ticks_ms;
332+
uint64_t start_ticks = supervisor_ticks_ms64();
334333
// Busy-wait for timeout.
335-
while (ticks_ms - start_ticks < self->timeout_ms) {
334+
while (supervisor_ticks_ms64() - start_ticks < self->timeout_ms) {
336335
if (usart_async_is_tx_empty(usart_desc_p)) {
337336
done = true;
338337
break;

‎ports/atmel-samd/common-hal/time/__init__.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828

2929
#include "shared-bindings/time/__init__.h"
3030

31-
#include "tick.h"
31+
#include "supervisor/shared/tick.h"
3232

3333
inline uint64_t common_hal_time_monotonic() {
34-
return ticks_ms;
34+
return supervisor_ticks_ms64();
3535
}
3636

3737
void common_hal_time_delay_ms(uint32_t delay) {

‎ports/atmel-samd/mphalport.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,12 @@
4545
#include "mpconfigboard.h"
4646
#include "mphalport.h"
4747
#include "reset.h"
48-
#include "tick.h"
48+
#include "supervisor/shared/tick.h"
4949

5050
extern uint32_t common_hal_mcu_processor_get_frequency(void);
5151

5252
void mp_hal_delay_ms(mp_uint_t delay) {
53-
uint64_t start_tick = ticks_ms;
53+
uint64_t start_tick = supervisor_ticks_ms64();
5454
uint64_t duration = 0;
5555
while (duration < delay) {
5656
RUN_BACKGROUND_TASKS;
@@ -59,7 +59,7 @@ void mp_hal_delay_ms(mp_uint_t delay) {
5959
MP_STATE_VM(mp_pending_exception) == MP_OBJ_FROM_PTR(&MP_STATE_VM(mp_reload_exception))) {
6060
break;
6161
}
62-
duration = (ticks_ms - start_tick);
62+
duration = (supervisor_ticks_ms64() - start_tick);
6363
// TODO(tannewt): Go to sleep for a little while while we wait.
6464
}
6565
}

‎ports/atmel-samd/mphalport.h‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131

3232
#include "lib/oofatfs/ff.h"
3333

34-
// Global millisecond tick count (driven by SysTick interrupt).
35-
extern volatile uint64_t ticks_ms;
34+
#include "supervisor/shared/tick.h"
3635

36+
// Global millisecond tick count (driven by SysTick interrupt).
3737
static inline mp_uint_t mp_hal_ticks_ms(void) {
38-
return ticks_ms;
38+
return supervisor_ticks_ms32();
3939
}
4040
// Number of bytes in receive buffer
4141
volatile uint8_t usb_rx_count;

‎ports/atmel-samd/tick.c‎

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -28,47 +28,21 @@
2828

2929
#include "peripheral_clk_config.h"
3030

31-
#include "supervisor/shared/autoreload.h"
32-
#include "supervisor/filesystem.h"
31+
#include "supervisor/shared/tick.h"
3332
#include "shared-bindings/microcontroller/__init__.h"
3433
#include "shared-bindings/microcontroller/Processor.h"
3534

36-
#if CIRCUITPY_GAMEPAD
37-
#include "shared-module/gamepad/__init__.h"
38-
#endif
39-
40-
#if CIRCUITPY_GAMEPADSHIFT
41-
#include "shared-module/gamepadshift/__init__.h"
42-
#endif
43-
// Global millisecond tick count
44-
volatile uint64_t ticks_ms = 0;
45-
4635
void SysTick_Handler(void) {
4736
// SysTick interrupt handler called when the SysTick timer reaches zero
4837
// (every millisecond).
4938
common_hal_mcu_disable_interrupts();
50-
ticks_ms += 1;
5139

5240
// Read the control register to reset the COUNTFLAG.
5341
(void) SysTick->CTRL;
5442
common_hal_mcu_enable_interrupts();
5543

56-
#if CIRCUITPY_FILESYSTEM_FLUSH_INTERVAL_MS > 0
57-
filesystem_tick();
58-
#endif
59-
#ifdef CIRCUITPY_AUTORELOAD_DELAY_MS
60-
autoreload_tick();
61-
#endif
62-
#ifdef CIRCUITPY_GAMEPAD_TICKS
63-
if (!(ticks_ms & CIRCUITPY_GAMEPAD_TICKS)) {
64-
#if CIRCUITPY_GAMEPAD
65-
gamepad_tick();
66-
#endif
67-
#if CIRCUITPY_GAMEPADSHIFT
68-
gamepadshift_tick();
69-
#endif
70-
}
71-
#endif
44+
// Do things common to all ports when the tick occurs
45+
supervisor_tick();
7246
}
7347

7448
void tick_init() {
@@ -115,7 +89,7 @@ void current_tick(uint64_t* ms, uint32_t* us_until_ms) {
11589
uint32_t tick_status = SysTick->CTRL;
11690
uint32_t current_us = SysTick->VAL;
11791
uint32_t tick_status2 = SysTick->CTRL;
118-
uint64_t current_ms = ticks_ms;
92+
uint64_t current_ms = supervisor_ticks_ms64();
11993
// The second clause ensures our value actually rolled over. Its possible it hit zero between
12094
// the VAL read and CTRL read.
12195
if ((tick_status & SysTick_CTRL_COUNTFLAG_Msk) != 0 ||
@@ -129,5 +103,5 @@ void current_tick(uint64_t* ms, uint32_t* us_until_ms) {
129103

130104
void wait_until(uint64_t ms, uint32_t us_until_ms) {
131105
uint32_t ticks_per_us = common_hal_mcu_processor_get_frequency() / 1000 / 1000;
132-
while (ticks_ms <= ms && SysTick->VAL / ticks_per_us >= us_until_ms) {}
106+
while (supervisor_ticks_ms64() <= ms && SysTick->VAL / ticks_per_us >= us_until_ms) {}
133107
}

‎ports/atmel-samd/tick.h‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@
2828

2929
#include "py/mpconfig.h"
3030

31-
extern volatile uint64_t ticks_ms;
32-
3331
extern struct timer_descriptor ms_timer;
3432

3533
void tick_init(void);

‎ports/cxd56/common-hal/time/__init__.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626

2727
#include "py/mphal.h"
2828

29-
#include "tick.h"
29+
#include "supervisor/shared/tick.h"
3030

3131
uint64_t common_hal_time_monotonic(void) {
32-
return ticks_ms;
32+
return supervisor_ticks_ms64();
3333
}
3434

3535
void common_hal_time_delay_ms(uint32_t delay) {

‎ports/cxd56/mphalport.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131

3232
#include "py/mpstate.h"
3333

34-
#include "tick.h"
34+
#include "supervisor/shared/tick.h"
3535

3636
#define DELAY_CORRECTION (700)
3737
#define DELAY_INTERVAL (50)
@@ -57,7 +57,7 @@ mp_uint_t mp_hal_ticks_cpu(void) {
5757
}
5858

5959
void mp_hal_delay_ms(mp_uint_t delay) {
60-
uint64_t start_tick = ticks_ms;
60+
uint64_t start_tick = supervisor_ticks_ms64();
6161
uint64_t duration = 0;
6262
while (duration < delay) {
6363
#ifdef MICROPY_VM_HOOK_LOOP
@@ -68,7 +68,7 @@ void mp_hal_delay_ms(mp_uint_t delay) {
6868
MP_STATE_VM(mp_pending_exception) == MP_OBJ_FROM_PTR(&MP_STATE_VM(mp_reload_exception))) {
6969
break;
7070
}
71-
duration = (ticks_ms - start_tick);
71+
duration = (supervisor_ticks_ms64() - start_tick);
7272
// TODO(tannewt): Go to sleep for a little while while we wait.
7373
}
7474
}

0 commit comments

Comments
 (0)