Skip to content

Commit 60ccb41

Browse files
owens-billpfalcon
authored andcommitted
esp8266: Move status() from esp module to network
1 parent 06593fb commit 60ccb41

3 files changed

Lines changed: 31 additions & 27 deletions

File tree

esp8266/modesp.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -509,11 +509,6 @@ void error_check(bool status, const char *msg) {
509509
}
510510
}
511511

512-
STATIC mp_obj_t esp_status() {
513-
return MP_OBJ_NEW_SMALL_INT(wifi_station_get_connect_status());
514-
}
515-
STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_status_obj, esp_status);
516-
517512
STATIC mp_obj_t esp_phy_mode(mp_uint_t n_args, const mp_obj_t *args) {
518513
if (n_args == 0) {
519514
return mp_obj_new_int(wifi_get_phy_mode());
@@ -568,7 +563,6 @@ STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_flash_id_obj, esp_flash_id);
568563
STATIC const mp_map_elem_t esp_module_globals_table[] = {
569564
{ MP_OBJ_NEW_QSTR(MP_QSTR___name__), MP_OBJ_NEW_QSTR(MP_QSTR_esp) },
570565

571-
{ MP_OBJ_NEW_QSTR(MP_QSTR_status), (mp_obj_t)&esp_status_obj },
572566
{ MP_OBJ_NEW_QSTR(MP_QSTR_mac), (mp_obj_t)&esp_mac_obj },
573567
{ MP_OBJ_NEW_QSTR(MP_QSTR_getaddrinfo), (mp_obj_t)&esp_getaddrinfo_obj },
574568
{ MP_OBJ_NEW_QSTR(MP_QSTR_phy_mode), (mp_obj_t)&esp_phy_mode_obj },
@@ -591,19 +585,6 @@ STATIC const mp_map_elem_t esp_module_globals_table[] = {
591585
MP_OBJ_NEW_SMALL_INT(LIGHT_SLEEP_T) },
592586
{ MP_OBJ_NEW_QSTR(MP_QSTR_SLEEP_MODEM),
593587
MP_OBJ_NEW_SMALL_INT(MODEM_SLEEP_T) },
594-
595-
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_IDLE),
596-
MP_OBJ_NEW_SMALL_INT(STATION_IDLE)},
597-
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_CONNECTING),
598-
MP_OBJ_NEW_SMALL_INT(STATION_CONNECTING)},
599-
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_WRONG_PASSWORD),
600-
MP_OBJ_NEW_SMALL_INT(STATION_WRONG_PASSWORD)},
601-
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_NO_AP_FOUND),
602-
MP_OBJ_NEW_SMALL_INT(STATION_NO_AP_FOUND)},
603-
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_CONNECT_FAIL),
604-
MP_OBJ_NEW_SMALL_INT(STATION_CONNECT_FAIL)},
605-
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_GOT_IP),
606-
MP_OBJ_NEW_SMALL_INT(STATION_GOT_IP)},
607588
#endif
608589
};
609590

esp8266/modnetwork.c

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,13 @@ STATIC mp_obj_t esp_disconnect() {
7171
}
7272
STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_disconnect_obj, esp_disconnect);
7373

74+
#define MODNETWORK_INCLUDE_CONSTANTS (1)
75+
76+
STATIC mp_obj_t esp_status() {
77+
return MP_OBJ_NEW_SMALL_INT(wifi_station_get_connect_status());
78+
}
79+
STATIC MP_DEFINE_CONST_FUN_OBJ_0(esp_status_obj, esp_status);
80+
7481
STATIC void esp_scan_cb(scaninfo *si, STATUS status) {
7582
struct bss_info *bs;
7683
if (si->pbss) {
@@ -107,7 +114,23 @@ STATIC const mp_map_elem_t mp_module_network_globals_table[] = {
107114
{ MP_OBJ_NEW_QSTR(MP_QSTR_WLAN), (mp_obj_t)&get_module_obj },
108115
{ MP_OBJ_NEW_QSTR(MP_QSTR_connect), (mp_obj_t)&esp_connect_obj },
109116
{ MP_OBJ_NEW_QSTR(MP_QSTR_disconnect), (mp_obj_t)&esp_disconnect_obj },
117+
{ MP_OBJ_NEW_QSTR(MP_QSTR_status), (mp_obj_t)&esp_status_obj },
110118
{ MP_OBJ_NEW_QSTR(MP_QSTR_scan), (mp_obj_t)&esp_scan_obj },
119+
120+
#if MODNETWORK_INCLUDE_CONSTANTS
121+
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_IDLE),
122+
MP_OBJ_NEW_SMALL_INT(STATION_IDLE)},
123+
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_CONNECTING),
124+
MP_OBJ_NEW_SMALL_INT(STATION_CONNECTING)},
125+
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_WRONG_PASSWORD),
126+
MP_OBJ_NEW_SMALL_INT(STATION_WRONG_PASSWORD)},
127+
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_NO_AP_FOUND),
128+
MP_OBJ_NEW_SMALL_INT(STATION_NO_AP_FOUND)},
129+
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_CONNECT_FAIL),
130+
MP_OBJ_NEW_SMALL_INT(STATION_CONNECT_FAIL)},
131+
{ MP_OBJ_NEW_QSTR(MP_QSTR_STAT_GOT_IP),
132+
MP_OBJ_NEW_SMALL_INT(STATION_GOT_IP)},
133+
#endif
111134
};
112135

113136
STATIC MP_DEFINE_CONST_DICT(mp_module_network_globals, mp_module_network_globals_table);

esp8266/qstrdefsport.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ Q(esp)
5656
Q(socket)
5757
Q(connect)
5858
Q(disconnect)
59-
Q(scan)
60-
Q(status)
6159
Q(phy_mode)
6260
Q(sleep_type)
6361
Q(deepsleep)
@@ -85,12 +83,6 @@ Q(onconnect)
8583
Q(onrecv)
8684
Q(onsent)
8785
Q(ondisconnect)
88-
Q(STAT_IDLE)
89-
Q(STAT_CONNECTING)
90-
Q(STAT_WRONG_PASSWORD)
91-
Q(STAT_NO_AP_FOUND)
92-
Q(STAT_CONNECT_FAIL)
93-
Q(STAT_GOT_IP)
9486
Q(MODE_11B)
9587
Q(MODE_11G)
9688
Q(MODE_11N)
@@ -101,6 +93,14 @@ Q(SLEEP_MODEM)
10193
// network module
10294
Q(network)
10395
Q(WLAN)
96+
Q(scan)
97+
Q(status)
98+
Q(STAT_IDLE)
99+
Q(STAT_CONNECTING)
100+
Q(STAT_WRONG_PASSWORD)
101+
Q(STAT_NO_AP_FOUND)
102+
Q(STAT_CONNECT_FAIL)
103+
Q(STAT_GOT_IP)
104104

105105
// Pin class
106106
Q(Pin)

0 commit comments

Comments
 (0)