Make function name more descriptive

jepler · jepler · commit 5fcba97a5185 · 2020-04-14T18:24:58.000-05:00
diff --git a/shared-bindings/_protomatter/Protomatter.c b/shared-bindings/_protomatter/Protomatter.c
@@ -62,15 +62,15 @@ STATIC void validate_pins(qstr what, uint8_t* pin_nos, mp_int_t max_pins, mp_obj
     }
 }
 
-STATIC void claim_pin_nr(mp_obj_t pin) {
+STATIC void claim_and_never_reset_pin(mp_obj_t pin) {
     common_hal_mcu_pin_claim(pin);
     common_hal_never_reset_pin(pin);
 }
 
-STATIC void claim_pins_nr(mp_obj_t seq) {
+STATIC void claim_and_never_reset_pins(mp_obj_t seq) {
     mp_int_t len = MP_OBJ_SMALL_INT_VALUE(mp_obj_len(seq));
     for (mp_int_t i=0; i<len; i++) {
-        claim_pin_nr(mp_obj_subscr(seq, MP_OBJ_NEW_SMALL_INT(i), MP_OBJ_SENTINEL));
+        claim_and_never_reset_pin(mp_obj_subscr(seq, MP_OBJ_NEW_SMALL_INT(i), MP_OBJ_SENTINEL));
     }
 }
 
@@ -157,11 +157,11 @@ STATIC mp_obj_t protomatter_protomatter_make_new(const mp_obj_type_t *type, size
         args[ARG_doublebuffer].u_bool,
         framebuffer, NULL);
 
-    claim_pins_nr(args[ARG_rgb_list].u_obj);
-    claim_pins_nr(args[ARG_addr_list].u_obj);
-    claim_pin_nr(args[ARG_clock_pin].u_obj);
-    claim_pin_nr(args[ARG_oe_pin].u_obj);
-    claim_pin_nr(args[ARG_latch_pin].u_obj);
+    claim_and_never_reset_pins(args[ARG_rgb_list].u_obj);
+    claim_and_never_reset_pins(args[ARG_addr_list].u_obj);
+    claim_and_never_reset_pin(args[ARG_clock_pin].u_obj);
+    claim_and_never_reset_pin(args[ARG_oe_pin].u_obj);
+    claim_and_never_reset_pin(args[ARG_latch_pin].u_obj);
 
     return MP_OBJ_FROM_PTR(self);
 }

Original file line number	Diff line number	Diff line change
`@@ -62,15 +62,15 @@ STATIC void validate_pins(qstr what, uint8_t* pin_nos, mp_int_t max_pins, mp_obj`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`
`65`		`-STATIC void claim_pin_nr(mp_obj_t pin) {`
	`65`	`+STATIC void claim_and_never_reset_pin(mp_obj_t pin) {`
`66`	`66`	`common_hal_mcu_pin_claim(pin);`
`67`	`67`	`common_hal_never_reset_pin(pin);`
`68`	`68`	`}`
`69`	`69`
`70`		`-STATIC void claim_pins_nr(mp_obj_t seq) {`
	`70`	`+STATIC void claim_and_never_reset_pins(mp_obj_t seq) {`
`71`	`71`	`mp_int_t len = MP_OBJ_SMALL_INT_VALUE(mp_obj_len(seq));`
`72`	`72`	`for (mp_int_t i=0; i<len; i++) {`
`73`		`- claim_pin_nr(mp_obj_subscr(seq, MP_OBJ_NEW_SMALL_INT(i), MP_OBJ_SENTINEL));`
	`73`	`+ claim_and_never_reset_pin(mp_obj_subscr(seq, MP_OBJ_NEW_SMALL_INT(i), MP_OBJ_SENTINEL));`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`
`@@ -157,11 +157,11 @@ STATIC mp_obj_t protomatter_protomatter_make_new(const mp_obj_type_t *type, size`
`157`	`157`	`args[ARG_doublebuffer].u_bool,`
`158`	`158`	`framebuffer, NULL);`
`159`	`159`
`160`		`- claim_pins_nr(args[ARG_rgb_list].u_obj);`
`161`		`- claim_pins_nr(args[ARG_addr_list].u_obj);`
`162`		`- claim_pin_nr(args[ARG_clock_pin].u_obj);`
`163`		`- claim_pin_nr(args[ARG_oe_pin].u_obj);`
`164`		`- claim_pin_nr(args[ARG_latch_pin].u_obj);`
	`160`	`+ claim_and_never_reset_pins(args[ARG_rgb_list].u_obj);`
	`161`	`+ claim_and_never_reset_pins(args[ARG_addr_list].u_obj);`
	`162`	`+ claim_and_never_reset_pin(args[ARG_clock_pin].u_obj);`
	`163`	`+ claim_and_never_reset_pin(args[ARG_oe_pin].u_obj);`
	`164`	`+ claim_and_never_reset_pin(args[ARG_latch_pin].u_obj);`
`165`	`165`
`166`	`166`	`return MP_OBJ_FROM_PTR(self);`
`167`	`167`	`}`