background_callback: Avoid CALLBACK_CRITICAL_BEGIN with nothing to do

jepler · jepler · commit 36b46465167f · 2020-07-15T09:26:47.000-05:00
CALLBACK_CRITICAL_BEGIN is heavyweight, but we can be confident we do
not have work to do as long as callback_head is NULL.

This gives back performance on nRF.
diff --git a/supervisor/shared/background_callback.c b/supervisor/shared/background_callback.c
@@ -61,8 +61,11 @@ void background_callback_add(background_callback_t *cb, background_callback_fun
 
 static bool in_background_callback;
 void background_callback_run_all() {
+    if (!callback_head) {
+        return;
+    }
     CALLBACK_CRITICAL_BEGIN;
-    if(in_background_callback) {
+    if (in_background_callback) {
         CALLBACK_CRITICAL_END;
         return;
     }
