Skip to content

Commit 2c55b40

Browse files
committed
use a MixerVoice constructor
1 parent 1ec4fae commit 2c55b40

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

shared-bindings/audiocore/MixerVoice.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,11 @@
5050
//|
5151
// TODO: support mono or stereo voices
5252
STATIC mp_obj_t audioio_mixervoice_make_new(const mp_obj_type_t *type, size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_args) {
53-
audioio_mixervoice_obj_t *self = m_new_obj(audioio_mixervoice_obj_t);
53+
audioio_mixervoice_obj_t *self = m_new_obj(audioio_mixervoice_obj_t);
5454
self->base.type = &audioio_mixervoice_type;
55-
self->sample = NULL;
56-
self->level = ((1 << 15)-1);
55+
56+
common_hal_audioio_mixervoice_construct(self);
57+
5758
return MP_OBJ_FROM_PTR(self);
5859
}
5960

shared-bindings/audiocore/MixerVoice.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
extern const mp_obj_type_t audioio_mixer_type;
3636
extern const mp_obj_type_t audioio_mixervoice_type;
3737

38+
void common_hal_audioio_mixervoice_construct(audioio_mixervoice_obj_t *self);
3839
void common_hal_audioio_mixervoice_set_parent(audioio_mixervoice_obj_t* self, audioio_mixer_obj_t *parent);
3940
void common_hal_audioio_mixervoice_play(audioio_mixervoice_obj_t* self, mp_obj_t sample, bool loop);
4041
void common_hal_audioio_mixervoice_stop(audioio_mixervoice_obj_t* self);

shared-module/audiocore/MixerVoice.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@
3232
#include "shared-module/audiocore/RawSample.h"
3333
#include "shared-module/audiocore/MixerVoice.h"
3434

35+
void common_hal_audioio_mixervoice_construct(audioio_mixervoice_obj_t *self) {
36+
self->sample = NULL;
37+
self->level = ((1 << 15) - 1);
38+
}
39+
3540
void common_hal_audioio_mixervoice_set_parent(audioio_mixervoice_obj_t* self, audioio_mixer_obj_t *parent) {
3641
self->parent = parent;
3742
}

0 commit comments

Comments
 (0)