py/objstringio: Add TODO comment about avoiding copying on .getvalue().

pfalcon · pfalcon · commit 2ae6697300ed · 2016-05-14T14:46:13.000+03:00
diff --git a/py/objstringio.c b/py/objstringio.c
@@ -95,6 +95,7 @@ STATIC mp_uint_t stringio_write(mp_obj_t o_in, const void *buf, mp_uint_t size,
 STATIC mp_obj_t stringio_getvalue(mp_obj_t self_in) {
     mp_obj_stringio_t *self = MP_OBJ_TO_PTR(self_in);
     check_stringio_is_open(self);
+    // TODO: Try to avoid copying string
     return mp_obj_new_str_of_type(STREAM_TO_CONTENT_TYPE(self), (byte*)self->vstr->buf, self->vstr->len);
 }
 STATIC MP_DEFINE_CONST_FUN_OBJ_1(stringio_getvalue_obj, stringio_getvalue);

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ STATIC mp_uint_t stringio_write(mp_obj_t o_in, const void *buf, mp_uint_t size,`
`95`	`95`	`STATIC mp_obj_t stringio_getvalue(mp_obj_t self_in) {`
`96`	`96`	`mp_obj_stringio_t *self = MP_OBJ_TO_PTR(self_in);`
`97`	`97`	`check_stringio_is_open(self);`
	`98`	`+ // TODO: Try to avoid copying string`
`98`	`99`	`return mp_obj_new_str_of_type(STREAM_TO_CONTENT_TYPE(self), (byte*)self->vstr->buf, self->vstr->len);`
`99`	`100`	`}`
`100`	`101`	`STATIC MP_DEFINE_CONST_FUN_OBJ_1(stringio_getvalue_obj, stringio_getvalue);`