Skip to content

Commit 29844db

Browse files
committed
Use boolean type for renumber_endpoints
1 parent a020f20 commit 29844db

2 files changed

Lines changed: 27 additions & 26 deletions

File tree

supervisor/supervisor.mk

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,6 @@ ifndef USB_HID_DEVICES
9494
USB_HID_DEVICES = "KEYBOARD,MOUSE,CONSUMER,GAMEPAD"
9595
endif
9696

97-
ifndef USB_RENUMBER_ENDPOINTS
98-
USB_RENUMBER_ENDPOINTS = 1
99-
endif
100-
10197
ifndef USB_CDC_EP_NUM_NOTIFICATION
10298
USB_CDC_EP_NUM_NOTIFICATION = 0
10399
endif
@@ -134,6 +130,30 @@ ifndef USB_MIDI_EP_NUM_IN
134130
USB_MIDI_EP_NUM_IN = 0
135131
endif
136132

133+
USB_DESCRIPTOR_ARGS = \
134+
--manufacturer $(USB_MANUFACTURER)\
135+
--product $(USB_PRODUCT)\
136+
--vid $(USB_VID)\
137+
--pid $(USB_PID)\
138+
--serial_number_length $(USB_SERIAL_NUMBER_LENGTH)\
139+
--devices $(USB_DEVICES)\
140+
--hid_devices $(USB_HID_DEVICES)\
141+
--cdc_ep_num_notification $(USB_CDC_EP_NUM_NOTIFICATION)\
142+
--cdc_ep_num_data_out $(USB_CDC_EP_NUM_DATA_OUT)\
143+
--cdc_ep_num_data_in $(USB_CDC_EP_NUM_DATA_IN)\
144+
--msc_ep_num_out $(USB_MSC_EP_NUM_OUT)\
145+
--msc_ep_num_in $(USB_MSC_EP_NUM_IN)\
146+
--hid_ep_num_out $(USB_HID_EP_NUM_OUT)\
147+
--hid_ep_num_in $(USB_HID_EP_NUM_IN)\
148+
--midi_ep_num_out $(USB_MIDI_EP_NUM_OUT)\
149+
--midi_ep_num_in $(USB_MIDI_EP_NUM_IN)\
150+
--output_c_file $(BUILD)/autogen_usb_descriptor.c\
151+
--output_h_file $(BUILD)/genhdr/autogen_usb_descriptor.h
152+
153+
ifeq ($(USB_RENUMBER_ENDPOINTS), 0)
154+
USB_DESCRIPTOR_ARGS += --no-renumber_endpoints
155+
endif
156+
137157
SUPERVISOR_O = $(addprefix $(BUILD)/, $(SRC_SUPERVISOR:.c=.o)) $(BUILD)/autogen_display_resources.o
138158

139159
$(BUILD)/supervisor/shared/translate.o: $(HEADER_BUILD)/qstrdefs.generated.h
@@ -145,26 +165,7 @@ $(BUILD)/autogen_usb_descriptor.c $(BUILD)/genhdr/autogen_usb_descriptor.h: auto
145165
autogen_usb_descriptor.intermediate: ../../tools/gen_usb_descriptor.py Makefile | $(HEADER_BUILD)
146166
$(STEPECHO) "GEN $@"
147167
$(Q)install -d $(BUILD)/genhdr
148-
$(Q)$(PYTHON3) ../../tools/gen_usb_descriptor.py \
149-
--manufacturer $(USB_MANUFACTURER)\
150-
--product $(USB_PRODUCT)\
151-
--vid $(USB_VID)\
152-
--pid $(USB_PID)\
153-
--serial_number_length $(USB_SERIAL_NUMBER_LENGTH)\
154-
--devices $(USB_DEVICES)\
155-
--hid_devices $(USB_HID_DEVICES)\
156-
--renumber_endpoints $(USB_RENUMBER_ENDPOINTS)\
157-
--cdc_ep_num_notification $(USB_CDC_EP_NUM_NOTIFICATION)\
158-
--cdc_ep_num_data_out $(USB_CDC_EP_NUM_DATA_OUT)\
159-
--cdc_ep_num_data_in $(USB_CDC_EP_NUM_DATA_IN)\
160-
--msc_ep_num_out $(USB_MSC_EP_NUM_OUT)\
161-
--msc_ep_num_in $(USB_MSC_EP_NUM_IN)\
162-
--hid_ep_num_out $(USB_HID_EP_NUM_OUT)\
163-
--hid_ep_num_in $(USB_HID_EP_NUM_IN)\
164-
--midi_ep_num_out $(USB_MIDI_EP_NUM_OUT)\
165-
--midi_ep_num_in $(USB_MIDI_EP_NUM_IN)\
166-
--output_c_file $(BUILD)/autogen_usb_descriptor.c\
167-
--output_h_file $(BUILD)/genhdr/autogen_usb_descriptor.h
168+
$(Q)$(PYTHON3) ../../tools/gen_usb_descriptor.py $(USB_DESCRIPTOR_ARGS)
168169

169170
CIRCUITPY_DISPLAY_FONT ?= "../../tools/fonts/ter-u12n.bdf"
170171

tools/gen_usb_descriptor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
help='devices to include in descriptor (AUDIO includes MIDI support)')
3333
parser.add_argument('--hid_devices', type=lambda l: tuple(l.split(',')), default=DEFAULT_HID_DEVICES,
3434
help='HID devices to include in HID report descriptor')
35-
parser.add_argument('--renumber_endpoints', type=int, default=1,
36-
help='use relative(1) or absolute(0) endpoint number')
35+
parser.add_argument('--no-renumber_endpoints', dest='renumber_endpoints', action='store_false',
36+
help='use to not renumber endpoint')
3737
parser.add_argument('--cdc_ep_num_notification', type=int, default=0,
3838
help='endpoint number of CDC NOTIFICATION')
3939
parser.add_argument('--cdc_ep_num_data_out', type=int, default=0,

0 commit comments

Comments
 (0)