Skip to content

Commit 1df4168

Browse files
committed
py/nlrthumb: Convert NLR thumb funcs from asm to C with inline-asm.
Now only the bits that really need to be written in assembler are written in it, otherwise C is used. This means that the assembler code no longer needs to know about the global state structure which makes it much easier to maintain.
1 parent c9520c5 commit 1df4168

2 files changed

Lines changed: 134 additions & 165 deletions

File tree

py/nlrthumb.S

Lines changed: 0 additions & 165 deletions
This file was deleted.

py/nlrthumb.c

Lines changed: 134 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,134 @@
1+
/*
2+
* This file is part of the MicroPython project, http://micropython.org/
3+
*
4+
* The MIT License (MIT)
5+
*
6+
* Copyright (c) 2013-2016 Damien P. George
7+
*
8+
* Permission is hereby granted, free of charge, to any person obtaining a copy
9+
* of this software and associated documentation files (the "Software"), to deal
10+
* in the Software without restriction, including without limitation the rights
11+
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
12+
* copies of the Software, and to permit persons to whom the Software is
13+
* furnished to do so, subject to the following conditions:
14+
*
15+
* The above copyright notice and this permission notice shall be included in
16+
* all copies or substantial portions of the Software.
17+
*
18+
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
19+
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
20+
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
21+
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
22+
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
23+
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
24+
* THE SOFTWARE.
25+
*/
26+
27+
#include "py/mpstate.h"
28+
#include "py/nlr.h"
29+
30+
#if (!defined(MICROPY_NLR_SETJMP) || !MICROPY_NLR_SETJMP) && (defined(__thumb2__) || defined(__thumb__) || defined(__arm__))
31+
32+
// We only need the functions here if we are on arm/thumb, and we are not
33+
// using setjmp/longjmp.
34+
//
35+
// For reference, arm/thumb callee save regs are:
36+
// r4-r11, r13=sp
37+
38+
__attribute__((naked)) unsigned int nlr_push(nlr_buf_t *nlr) {
39+
40+
__asm volatile (
41+
"str r4, [r0, #12] \n" // store r4 into nlr_buf
42+
"str r5, [r0, #16] \n" // store r5 into nlr_buf
43+
"str r6, [r0, #20] \n" // store r6 into nlr_buf
44+
"str r7, [r0, #24] \n" // store r7 into nlr_buf
45+
46+
#if defined(__ARM_ARCH_6M__)
47+
"mov r1, r8 \n"
48+
"str r1, [r0, #28] \n" // store r8 into nlr_buf
49+
"mov r1, r9 \n"
50+
"str r1, [r0, #32] \n" // store r9 into nlr_buf
51+
"mov r1, r10 \n"
52+
"str r1, [r0, #36] \n" // store r10 into nlr_buf
53+
"mov r1, r11 \n"
54+
"str r1, [r0, #40] \n" // store r11 into nlr_buf
55+
"mov r1, r13 \n"
56+
"str r1, [r0, #44] \n" // store r13=sp into nlr_buf
57+
"mov r1, lr \n"
58+
"str r1, [r0, #8] \n" // store lr into nlr_buf
59+
#else
60+
"str r8, [r0, #28] \n" // store r8 into nlr_buf
61+
"str r9, [r0, #32] \n" // store r9 into nlr_buf
62+
"str r10, [r0, #36] \n" // store r10 into nlr_buf
63+
"str r11, [r0, #40] \n" // store r11 into nlr_buf
64+
"str r13, [r0, #44] \n" // store r13=sp into nlr_buf
65+
"str lr, [r0, #8] \n" // store lr into nlr_buf
66+
#endif
67+
68+
"b nlr_push_tail \n" // do the rest in C
69+
);
70+
71+
return 0; // needed to silence compiler warning
72+
}
73+
74+
unsigned int nlr_push_tail(nlr_buf_t *nlr) {
75+
nlr_buf_t **top = &MP_STATE_THREAD(nlr_top);
76+
nlr->prev = *top;
77+
*top = nlr;
78+
return 0; // normal return
79+
}
80+
81+
void nlr_pop(void) {
82+
nlr_buf_t **top = &MP_STATE_THREAD(nlr_top);
83+
*top = (*top)->prev;
84+
}
85+
86+
NORETURN __attribute__((naked)) void nlr_jump(void *val) {
87+
nlr_buf_t **top_ptr = &MP_STATE_THREAD(nlr_top);
88+
nlr_buf_t *top = *top_ptr;
89+
if (top == NULL) {
90+
nlr_jump_fail(val);
91+
}
92+
93+
top->ret_val = val;
94+
*top_ptr = top->prev;
95+
96+
__asm volatile (
97+
"mov r0, %0 \n" // r0 points to nlr_buf
98+
"ldr r4, [r0, #12] \n" // load r4 from nlr_buf
99+
"ldr r5, [r0, #16] \n" // load r5 from nlr_buf
100+
"ldr r6, [r0, #20] \n" // load r6 from nlr_buf
101+
"ldr r7, [r0, #24] \n" // load r7 from nlr_buf
102+
103+
#if defined(__ARM_ARCH_6M__)
104+
"ldr r1, [r0, #28] \n" // load r8 from nlr_buf
105+
"mov r8, r1 \n"
106+
"ldr r1, [r0, #32] \n" // load r9 from nlr_buf
107+
"mov r9, r1 \n"
108+
"ldr r1, [r0, #36] \n" // load r10 from nlr_buf
109+
"mov r10, r1 \n"
110+
"ldr r1, [r0, #40] \n" // load r11 from nlr_buf
111+
"mov r11, r1 \n"
112+
"ldr r1, [r0, #44] \n" // load r13=sp from nlr_buf
113+
"mov r13, r1 \n"
114+
"ldr r1, [r0, #8] \n" // load lr from nlr_buf
115+
"mov lr, r1 \n"
116+
#else
117+
"ldr r8, [r0, #28] \n" // load r8 from nlr_buf
118+
"ldr r9, [r0, #32] \n" // load r9 from nlr_buf
119+
"ldr r10, [r0, #36] \n" // load r10 from nlr_buf
120+
"ldr r11, [r0, #40] \n" // load r11 from nlr_buf
121+
"ldr r13, [r0, #44] \n" // load r13=sp from nlr_buf
122+
"ldr lr, [r0, #8] \n" // load lr from nlr_buf
123+
#endif
124+
"movs r0, #1 \n" // return 1, non-local return
125+
"bx lr \n" // return
126+
: // output operands
127+
: "r"(top) // input operands
128+
: // clobbered registers
129+
);
130+
131+
for (;;); // needed to silence compiler warning
132+
}
133+
134+
#endif // (!defined(MICROPY_NLR_SETJMP) || !MICROPY_NLR_SETJMP) && (defined(__thumb2__) || defined(__thumb__) || defined(__arm__))

0 commit comments

Comments
 (0)