-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathuserGroupSync.test.ts
More file actions
344 lines (316 loc) · 10.7 KB
/
Copy pathuserGroupSync.test.ts
File metadata and controls
344 lines (316 loc) · 10.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
import { describe, expect, it } from "vitest";
import {
parseUserExportCsv,
planUserGroupSync,
renderGroupName,
type ExistingUserGroup,
type ResolvedStackUser,
} from "./userGroupSync";
const csv = [
"Director,Senior Manager,User Group Member,First Name,Last Name,Colleague ID,Email,Job Title",
"Pat Director,Ada Lovelace,Grace Hopper,Grace,Hopper,1001,grace@example.com,Engineer",
"Pat Director,Ada Lovelace,Linus Torvalds,Linus,Torvalds,1002,linus@example.com,Engineer",
"Pat Director,Alan Turing,Katherine Johnson,Katherine,Johnson,1003,katherine@example.com,Analyst",
].join("\n");
describe("parseUserExportCsv", () => {
it("accepts the expected user export headers and normalizes rows", () => {
expect(parseUserExportCsv(csv)).toEqual([
expect.objectContaining({
rowNumber: 2,
seniorManager: "Ada Lovelace",
email: "grace@example.com",
}),
expect.objectContaining({
rowNumber: 3,
seniorManager: "Ada Lovelace",
email: "linus@example.com",
}),
expect.objectContaining({
rowNumber: 4,
seniorManager: "Alan Turing",
email: "katherine@example.com",
}),
]);
});
it("reports missing required columns", () => {
expect(() => parseUserExportCsv("Senior Manager,Email\nAda Lovelace,ada@example.com")).toThrow(
"User export CSV is missing required column(s): Director, User Group Member, First Name, Last Name, Colleague ID, Job Title",
);
});
});
describe("renderGroupName", () => {
it("renders the configurable senior-manager template", () => {
expect(renderGroupName("{Senior Manager} VRM", "Ada Lovelace")).toBe("Ada Lovelace VRM");
expect(renderGroupName("VRM - {Senior Manager}", "Ada Lovelace")).toBe("VRM - Ada Lovelace");
});
});
describe("planUserGroupSync", () => {
const resolvedUsers: Record<string, ResolvedStackUser | null> = {
"grace@example.com": { id: 1, email: "grace@example.com", name: "Grace Hopper" },
"linus@example.com": { id: 2, email: "linus@example.com", name: "Linus Torvalds" },
"katherine@example.com": { id: 3, email: "katherine@example.com", name: "Katherine Johnson" },
};
const existingGroups: ExistingUserGroup[] = [
{
id: 10,
name: "Ada Lovelace VRM",
users: [
{ id: 1, name: "Grace Hopper" },
{ id: 99, name: "Former Member" },
],
},
];
it("plans add-only creates and additions without removals", () => {
const plan = planUserGroupSync({
rows: parseUserExportCsv(csv),
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "add-only",
existingGroups,
resolvedUsers,
});
expect(plan.blockingErrors).toEqual([]);
expect(plan.groups).toEqual([
expect.objectContaining({
manager: "Ada Lovelace",
groupName: "Ada Lovelace VRM",
existingGroupId: 10,
createGroup: false,
desiredUserIds: [1, 2],
addUserIds: [2],
removeUserIds: [],
}),
expect.objectContaining({
manager: "Alan Turing",
groupName: "Alan Turing VRM",
existingGroupId: null,
createGroup: true,
desiredUserIds: [3],
addUserIds: [3],
removeUserIds: [],
}),
]);
});
it("plans exact-sync removals for matching generated groups", () => {
const plan = planUserGroupSync({
rows: parseUserExportCsv(csv),
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "exact-sync",
existingGroups,
resolvedUsers,
});
expect(plan.groups[0]).toEqual(expect.objectContaining({ removeUserIds: [99] }));
});
it("records skipped rows for blank values, duplicates, and unresolved emails", () => {
const rows = parseUserExportCsv(
[
"Director,Senior Manager,User Group Member,First Name,Last Name,Colleague ID,Email,Job Title",
"Pat Director,,Grace Hopper,Grace,Hopper,1001,grace@example.com,Engineer",
"Pat Director,Ada Lovelace,Missing Email,Missing,Email,1002,,Engineer",
"Pat Director,Ada Lovelace,Grace Hopper,Grace,Hopper,1003,grace@example.com,Engineer",
"Pat Director,Ada Lovelace,Grace Hopper Again,Grace,Hopper,1004,GRACE@example.com,Engineer",
"Pat Director,Ada Lovelace,Unresolved User,Unresolved,User,1005,nope@example.com,Engineer",
].join("\n"),
);
const plan = planUserGroupSync({
rows,
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "add-only",
existingGroups: [],
resolvedUsers: {
"grace@example.com": { id: 1, email: "grace@example.com", name: "Grace Hopper" },
"nope@example.com": null,
},
});
expect(plan.skippedRows).toEqual([
{
rowNumber: 2,
email: "grace@example.com",
seniorManager: "",
reason: "Missing Senior Manager",
},
{
rowNumber: 3,
email: "",
seniorManager: "Ada Lovelace",
reason: "Missing Email",
},
{
rowNumber: 5,
email: "GRACE@example.com",
seniorManager: "Ada Lovelace",
reason: "Duplicate Email",
},
{
rowNumber: 6,
email: "nope@example.com",
seniorManager: "Ada Lovelace",
reason: "Email not found in Stack Enterprise",
},
]);
});
it("does not let a missing-manager row reserve its email", () => {
const rows = parseUserExportCsv(
[
"Director,Senior Manager,User Group Member,First Name,Last Name,Colleague ID,Email,Job Title",
"Pat Director,,Grace Hopper,Grace,Hopper,1001,grace@example.com,Engineer",
"Pat Director,Ada Lovelace,Grace Hopper,Grace,Hopper,1002,GRACE@example.com,Engineer",
].join("\n"),
);
const plan = planUserGroupSync({
rows,
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "add-only",
existingGroups: [],
resolvedUsers: {
"grace@example.com": { id: 1, email: "grace@example.com", name: "Grace Hopper" },
},
});
expect(plan.skippedRows).toEqual([
{
rowNumber: 2,
email: "grace@example.com",
seniorManager: "",
reason: "Missing Senior Manager",
},
]);
expect(plan.groups).toEqual([
expect.objectContaining({
manager: "Ada Lovelace",
desiredUserIds: [1],
addUserIds: [1],
}),
]);
});
it("detects duplicate emails case-insensitively after a valid row claims the email", () => {
const rows = parseUserExportCsv(
[
"Director,Senior Manager,User Group Member,First Name,Last Name,Colleague ID,Email,Job Title",
"Pat Director,Ada Lovelace,Grace Hopper,Grace,Hopper,1001,Grace@Example.com,Engineer",
"Pat Director,Ada Lovelace,Grace Hopper Again,Grace,Hopper,1002,grace@example.com,Engineer",
].join("\n"),
);
const plan = planUserGroupSync({
rows,
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "add-only",
existingGroups: [],
resolvedUsers: {
"grace@example.com": { id: 1, email: "grace@example.com", name: "Grace Hopper" },
},
});
expect(plan.groups[0]).toEqual(expect.objectContaining({ desiredUserIds: [1] }));
expect(plan.skippedRows).toEqual([
{
rowNumber: 3,
email: "grace@example.com",
seniorManager: "Ada Lovelace",
reason: "Duplicate Email",
},
]);
});
it("matches existing groups case-insensitively after trimming whitespace", () => {
const plan = planUserGroupSync({
rows: parseUserExportCsv(csv),
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "add-only",
existingGroups: [
{
id: 42,
name: " ada lovelace vrm ",
users: [{ id: 1, name: "Grace Hopper" }],
},
],
resolvedUsers,
});
expect(plan.groups[0]).toEqual(
expect.objectContaining({
groupName: "Ada Lovelace VRM",
existingGroupId: 42,
createGroup: false,
addUserIds: [2],
}),
);
});
it("blocks apply when the template renders a blank group name", () => {
const plan = planUserGroupSync({
rows: parseUserExportCsv(
[
"Director,Senior Manager,User Group Member,First Name,Last Name,Colleague ID,Email,Job Title",
"Pat Director,Ada Lovelace,Grace Hopper,Grace,Hopper,1001,grace@example.com,Engineer",
].join("\n"),
),
groupNameTemplate: " ",
syncMode: "add-only",
existingGroups: [],
resolvedUsers,
});
expect(plan.blockingErrors).toEqual([
"Group name template produced a blank group name for Senior Manager value(s): Ada Lovelace.",
]);
});
it("sorts groups and user id changes deterministically", () => {
const rows = parseUserExportCsv(
[
"Director,Senior Manager,User Group Member,First Name,Last Name,Colleague ID,Email,Job Title",
"Pat Director,Beta Manager,Beta User,Beta,User,1001,beta@example.com,Engineer",
"Pat Director,Alpha Manager,Alpha Four,Alpha,Four,1002,alpha4@example.com,Engineer",
"Pat Director,Gamma Manager,Gamma User,Gamma,User,1003,gamma@example.com,Engineer",
"Pat Director,Alpha Manager,Alpha Two,Alpha,Two,1004,alpha2@example.com,Engineer",
].join("\n"),
);
const plan = planUserGroupSync({
rows,
groupNameTemplate: "{Senior Manager} VRM",
syncMode: "exact-sync",
existingGroups: [
{
id: 101,
name: "Alpha Manager VRM",
users: [{ id: 7 }, { id: 2 }],
},
{
id: 102,
name: "Beta Manager VRM",
users: [{ id: 5 }, { id: 1 }],
},
],
resolvedUsers: {
"beta@example.com": { id: 5, email: "beta@example.com" },
"alpha4@example.com": { id: 4, email: "alpha4@example.com" },
"gamma@example.com": { id: 3, email: "gamma@example.com" },
"alpha2@example.com": { id: 2, email: "alpha2@example.com" },
},
});
expect(plan.groups.map((group) => group.groupName)).toEqual([
"Alpha Manager VRM",
"Beta Manager VRM",
"Gamma Manager VRM",
]);
expect(plan.groups[0]).toEqual(
expect.objectContaining({
desiredUserIds: [2, 4],
addUserIds: [4],
removeUserIds: [7],
}),
);
expect(plan.groups[1]).toEqual(
expect.objectContaining({
desiredUserIds: [5],
addUserIds: [],
removeUserIds: [1],
}),
);
});
it("blocks apply when distinct managers render to the same group name", () => {
const plan = planUserGroupSync({
rows: parseUserExportCsv(csv),
groupNameTemplate: "VRM",
syncMode: "add-only",
existingGroups: [],
resolvedUsers,
});
expect(plan.blockingErrors).toEqual([
'Group name "VRM" is produced by multiple Senior Manager values: Ada Lovelace, Alan Turing.',
]);
});
});