Skip to content

Commit dca6f74

Browse files
yaoyu-33pre-commit-ci[bot]athittenpablo-garay
authored
Remove precision args in trainer due to PTL update (NVIDIA-NeMo#8908)
* Fix precision args in trainer due to PTL update Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * roll back one change Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> --------- Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Abhishree Thittenamane <47577437+athitten@users.noreply.github.com> Co-authored-by: Pablo Garay <palenq@gmail.com>
1 parent de983ff commit dca6f74

7 files changed

Lines changed: 9 additions & 13 deletions

File tree

‎examples/multimodal/multimodal_llm/neva/convert_hf_llava_to_neva.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ def convert(args):
205205
nemo_config.precision = precision
206206
print(f"nemo_config: {nemo_config}")
207207

208-
trainer = Trainer(plugins=plugins, accelerator='cpu', precision=precision, strategy=NLPDDPStrategy())
208+
trainer = Trainer(plugins=plugins, accelerator='cpu', strategy=NLPDDPStrategy())
209209

210210
hidden_size = hf_config["hidden_size"]
211211
head_num = hf_config["num_attention_heads"]

‎examples/nlp/language_modeling/megatron_change_num_partitions.py‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ def main():
938938
# Set precision None after precision plugins are created as PTL >= 2.1 does not allow both
939939
# precision plugins and precision to exist
940940
precision = None
941-
trainer = Trainer(plugins=plugins, devices=1, strategy=NLPDDPStrategy(), accelerator="cpu", precision=precision)
941+
trainer = Trainer(plugins=plugins, devices=1, strategy=NLPDDPStrategy(), accelerator="cpu")
942942

943943
if tp_size < 0 or pp_size < 0:
944944
logging.info(f"Loading model config from {args.model_file} to get TP and PP size")
@@ -1205,9 +1205,7 @@ def main():
12051205
if vp_size > 1:
12061206
set_virtual_parallel_rank_safely(None)
12071207

1208-
trainer = Trainer(
1209-
plugins=plugins, devices=1, strategy=NLPDDPStrategy(), accelerator="cpu", precision=precision
1210-
)
1208+
trainer = Trainer(plugins=plugins, devices=1, strategy=NLPDDPStrategy(), accelerator="cpu")
12111209

12121210
with open_dict(model.cfg):
12131211
if args.tokenizer_model_path is not None:
@@ -1413,9 +1411,7 @@ def main():
14131411
app_state.pipeline_model_parallel_size * app_state.tensor_model_parallel_size
14141412
)
14151413

1416-
trainer = Trainer(
1417-
plugins=plugins, devices=1, strategy=NLPDDPStrategy(), accelerator="cpu", precision=precision
1418-
)
1414+
trainer = Trainer(plugins=plugins, devices=1, strategy=NLPDDPStrategy(), accelerator="cpu")
14191415
if args.tokenizer_model_path is not None:
14201416
with open_dict(model.cfg):
14211417
model.cfg.tokenizer.model = args.tokenizer_model_path

‎scripts/checkpoint_converters/convert_baichuan2_hf_to_nemo.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def convert(args):
175175
nemo_config.precision = precision
176176
print(f"nemo_config: {nemo_config}")
177177

178-
trainer = Trainer(plugins=plugins, accelerator='cpu', precision=precision, strategy=NLPDDPStrategy())
178+
trainer = Trainer(plugins=plugins, accelerator='cpu', strategy=NLPDDPStrategy())
179179

180180
hidden_size = hf_config["hidden_size"]
181181
head_num = hf_config["num_attention_heads"]

‎scripts/checkpoint_converters/convert_chatglm_hf_to_nemo.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ def convert(args):
142142

143143
nemo_config.precision = precision
144144

145-
trainer = Trainer(plugins=plugins, accelerator='cpu', precision=precision, strategy=NLPDDPStrategy())
145+
trainer = Trainer(plugins=plugins, accelerator='cpu', strategy=NLPDDPStrategy())
146146

147147
hidden_size = hf_config["hidden_size"]
148148
head_num = hf_config["num_attention_heads"]

‎scripts/checkpoint_converters/convert_mistral_7b_hf_to_nemo.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ def convert(args):
193193
nemo_config.precision = precision
194194
logging.info(f"nemo_config: {nemo_config}")
195195

196-
trainer = Trainer(plugins=plugins, accelerator='cpu', precision=precision, strategy=NLPDDPStrategy())
196+
trainer = Trainer(plugins=plugins, accelerator='cpu', strategy=NLPDDPStrategy())
197197

198198
hidden_size = nemo_config.hidden_size
199199
head_num = nemo_config.num_attention_heads

‎scripts/checkpoint_converters/convert_mixtral_hf_to_nemo.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def convert(args):
194194
nemo_config.precision = precision
195195
print(f"nemo_config: {nemo_config}")
196196

197-
trainer = Trainer(plugins=plugins, accelerator='cpu', precision=precision, strategy=NLPDDPStrategy())
197+
trainer = Trainer(plugins=plugins, accelerator='cpu', strategy=NLPDDPStrategy())
198198

199199
hidden_size = nemo_config.hidden_size
200200
head_num = nemo_config.num_attention_heads

‎scripts/checkpoint_converters/convert_starcoder2_hf_to_nemo.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def convert(args):
194194
nemo_config.precision = precision
195195
logging.info(f"nemo_config: {nemo_config}")
196196

197-
trainer = Trainer(plugins=plugins, accelerator='cpu', precision=precision, strategy=NLPDDPStrategy())
197+
trainer = Trainer(plugins=plugins, accelerator='cpu', strategy=NLPDDPStrategy())
198198

199199
hidden_size = nemo_config.hidden_size
200200
head_num = nemo_config.num_attention_heads

0 commit comments

Comments
 (0)