forked from green-code-initiative/creedengo-java
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathAvoidMultipleIfElseStatement.java
More file actions
283 lines (243 loc) · 9.52 KB
/
AvoidMultipleIfElseStatement.java
File metadata and controls
283 lines (243 loc) · 9.52 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
/*
* ecoCode - Java language - Provides rules to reduce the environmental footprint of your Java programs
* Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
package fr.greencodeinitiative.java.checks;
class AvoidMultipleIfElseStatementCheck {
// /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// //
// // NON COMPLIANT use cases
// //
// /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// /////////////////////////////////////////////////////////////////////////////////////////////////////////////////
// NON COMPLIANT
// USE CASE : Non compliant use case to check if following is NON OK :
// - two uses of the same variable
// - usage of the same variable on different levels of IF statements
public int shouldBeCompliantBecauseVariableUsedMaximumTwiceInComposedElseStatements()
{
int nb1 = 0;
if (nb1 == 1) {
nb1 = 2;
} else {
if (nb1 == 2) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 1;
}
}
return nb1;
}
// NON COMPLIANT
// USE CASE : non compliant use case to check if a variable is not used max twice on several IF / ELSE statements
// at the same level
public int shouldBeNotCompliantBecauseVariablesUsedMaximumTwiceAndDifferentsVariablesUsed()
{
int nb1 = 0;
int nb2 = 0;
int nb3 = 0;
if (nb3 == 1
&& nb3 == 2
&& nb3 == 3) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 1;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb2 = 2;
}
if (nb2 == 2) {
nb1 = 3;
} else {
nb1 = 4;
}
return nb1;
}
// NON COMPLIANT
// USE CASE : NON compliant use case to check if following is NOT COMPLIANT :
// one variable is used maximum in two IF / ELSE / ELSEIF statements
public int shouldBeNotCompliantBecauseVariablesIsUsedMoreThanTwice()
{
int nb1 = 0;
if (nb1 == 1) {
nb1 = 2;
} else {
nb1 = 3;
}
if (nb1 == 2) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 4;
}
return nb1;
}
// NON COMPLIANT
// USE CASE : NON compliant use case to check if following is NOT OK :
// - same variable used maximum twice : no compliant because 2 IFs and 1 ELSE
public int shouldBeNotCompliantBecauseVariableUsedMoreThanTwiceInIfStatementsAtDifferentsLevels()
{
int nb1 = 0;
if (nb1 == 1) {
if (nb1 == 2) {
nb1 = 1;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 3;
}
} else {
nb1 = 2;
}
return nb1;
}
// NON COMPLIANT
// USE CASE : non compliant use case to check if following is NOT OK :
// - two uses of the same variable : use thre times with 2 IFs and 1 ELSE
// - usage of the same variable on different levels of IF statements
public int shouldBeNotCompliantBecauseVariableUsedMoreThanTwiceInComposedElseStatements()
{
int nb1 = 0;
if (nb1 == 1) {
nb1 = 2;
} else {
if (nb1 == 2) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 1;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 3;
}
}
return nb1;
}
// NON COMPLIANT
// USE CASE : non compliant use case to check if following is NOT OK :
// - two uses of the same variable : use thre times with 2 IFs and 1 ELSE
// - usage of the same variable on different levels of IF statements
public int shouldBeNotCompliantBecauseVariableUsedMoreThanTwiceInComposedElseStatementsScenario2()
{
int nb1 = 0;
if (nb1 == 1) {
if (nb1 == 3) {
nb1 = 4;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 5;
}
} else {
if (nb1 == 2) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 1;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 3;
}
}
return nb1;
}
// NON COMPLIANT
// USE CASE : non compliant use case to check if following is NOT OK :
// - two uses of the same variable : use thre times with 2 IFs and 1 ELSE
// - usage of the same variable on different levels of IF statements
public int shouldBeNotCompliantBecauseVariableUsedMoreThanTwiceInComposedElseStatementsScenario3()
{
int nb1 = 0;
int nb2 = 0;
if (nb1 == 1) {
if (nb1 == 3) {
nb1 = 4;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 5;
}
} else if (nb2 == 2) {
if (nb1 == 4) {
nb1 = 5;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 6;
}
}
return nb1;
}
// NON COMPLIANT
// USE CASE : non compliant use case to check if following is NOT OK :
// - two uses of the same variable : use thre times with 2 IFs and 1 ELSE
// - usage of the same variable on different levels of IF statements
public int shouldBeNotCompliantBecauseVariableUsedMoreThanTwiceInComposedElseStatementsScenario4()
{
int nb1 = 0;
int nb2 = 0;
if (nb1 == 1) {
if (nb2 == 3) {
nb1 = 4;
} else {
nb1 = 5;
}
} else if (nb2 == 2) {
if (nb1 == 3) {
nb1 = 4;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 5;
}
}
return nb1;
}
// NON COMPLIANT
// USE CASE : NON compliant use case to check if following is NOT OK :
// - the same variable must used maximum twice
// - usage of the same variable on different levels of IF / ELSE statements
public int shouldBeNotCompliantBecauseVariableUsedMaximumTwiceInComposedElseStatements()
{
int nb1 = 0;
if (nb1 == 1) {
nb1 = 2;
} else {
if (nb1 == 2) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 1;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
if (nb1 == 3) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 4;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb1 = 5;
}
}
}
return nb1;
}
// NON COMPLIANT
// USE CASE : NON compliant use case to check if following is NOT OK :
// - more than twice uses of the same variable
// - usage of the same variable on different kind of test statements (IF and ELSEIF)
public int shouldBeNotCompliantBecauseTheSameVariableIsUsedMoreThanTwice() // NOT Compliant
{
int nb1 = 0;
int nb2 = 10;
if (nb1 == 1) {
nb2 = 1;
} else if (nb1 == nb2) {
nb2 = 2;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb2 = 4;
}
return nb2;
}
// NON COMPLIANT
// USE CASE : NON compliant use case to check if following is NOT OK :
// - more than twice uses of the same variable
// - usage of the same variable on different kind of test statements (IF and ELSEIF)
public int shouldBeNotCompliantBecauseTheSameVariableIsUsedManyTimes() // NOT Compliant
{
int nb1 = 0;
int nb2 = 10;
int nb3 = 11;
if (nb1 == 1) {
nb2 = 1;
} else if (nb1 == nb2) {
nb2 = 2;
} else if (nb3 == nb1) { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb2 = 3;
} else { // Noncompliant {{Use a switch statement instead of multiple if-else if possible}}
nb2 = 4;
}
return nb2;
}
}