Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SpatialAudioKit/SAKTestResources
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: SpatialAudioKit/SAKTestResources
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fixtures/classification
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 18 files changed
  • 1 contributor

Commits on Jul 17, 2026

  1. Make unsupportedFile.mid a real MIDI file 

    The old fixture was MP3 audio with a .mid extension — a decoy for
extension-based routing. Content-driven detection now sniffs it as MP3 and
correctly plays it, which defeats the unsupported-format tests. A genuine
(empty) MIDI file keeps those tests exercising truly undecodable content.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    df969e2 View commit details
    Browse the repository at this point in the history

  2. Add generated classification fixtures and generator script 

    Tone-per-channel fixtures (channel N = distinct frequency) for the
classifier and bed-routing tests: mono/stereo, tagged quad/5.1/7.1/octo/
7.1.4-Atmos CAFs, and untagged 4/6/8ch WAVs for the channel-count
fallback paths. Reproducible via Scripts/generate_fixtures.py
(python + afconvert, layouts verified with afinfo).
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    e228fc6 View commit details
    Browse the repository at this point in the history

  3. Add tagged fixtures for the remaining Atmos beds 

    512/514/712/916 join 714: every Atmos-family layout the classifier and
Renderer3 support now has a tone-per-channel fixture.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    4e7a6a7 View commit details
    Browse the repository at this point in the history

  4. Add on-the-fly channel-ID generator for bed layouts 

    Spoken per-channel labels (macOS say) in Core Audio tag order, LFE as a
low tone burst; outputs CAF, AAC/m4a (transport-order layouts where AAC
has one) and opus (ffmpeg; family 255 above 8 channels). Output dir is
gitignored — files are generated on demand.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    128ed7c View commit details
    Browse the repository at this point in the history

  5. Fix opus bed layouts and add on-the-fly channel-ID pipeline test 

    Two opus layout-mapper fixes surfaced by the channel-ID work: family-255
streams with unmapped channel counts now report an honest DiscreteInOrder
tag (the old Stereo fallback mislabelled e.g. 10-channel files, defeating
the classifier's count policy), and DTS_7_1 joins the classifier's 7.1
variants so 8-channel discrete opus classifies as a bed.

SAKChannelIDBedTests invokes the resources submodule's generator script
on the fly (5.1 and 7.1.4 in CAF, AAC/m4a and opus where tools allow)
and verifies each file classifies to the right bed from its real
container metadata, routes to the Apple renderer, and audibly plays —
skipping cleanly where TTS or ffmpeg is unavailable. Resources submodule
pinned with the generator script.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    37e60d8 View commit details
    Browse the repository at this point in the history

  6. Prefix channel-ID announcements with the channel number 

    Several labels share words (five 7.1.4 channels contain 'left'), which
made sequential playback sound like repetition. The spoken channel
number makes each announcement unique by ear and mis-routing obvious.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    59a90aa View commit details
    Browse the repository at this point in the history

  7. Revert "Fix opus bed layouts and add on-the-fly channel-ID pipeline t… 

    …est"

This reverts commit 37e60d8.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    e570008 View commit details
    Browse the repository at this point in the history

  8. Give channel-ID announcements more breathing room 

    2.0 s slots (numbered labels no longer risk truncation) with 0.6 s gaps.
    @olilarkin
    olilarkin committed Jul 17, 2026
    Configuration menu
    Copy the full SHA
    f153fc0 View commit details
    Browse the repository at this point in the history
Loading