fix: leave arrays in json (googleapis#13052)

MeilakhSiarhei · web-flow · commit 4bc910b5e4e6 · 2023-11-07T16:21:10.000+01:00
This functionality replaces all arrays with `&lt;discarded&gt;` value, making the json invalid. It happens even if the array is not empty.
diff --git a/google/cloud/bigquery/v2/minimal/internal/json_utils.cc b/google/cloud/bigquery/v2/minimal/internal/json_utils.cc
@@ -109,9 +109,6 @@ nlohmann::json RemoveJsonKeysAndEmptyFields(
         if (event == nlohmann::json::parse_event_t::object_end) {
           return parsed != nullptr && !parsed.empty();
         }
-        if (event == nlohmann::json::parse_event_t::array_end) {
-          return !parsed.empty();
-        }
         return true;
       };
   return nlohmann::json::parse(json_payload, remove_empty_call_back, false);
diff --git a/google/cloud/bigquery/v2/minimal/internal/json_utils_test.cc b/google/cloud/bigquery/v2/minimal/internal/json_utils_test.cc
@@ -229,17 +229,6 @@ TEST(JsonUtilsTest, RemoveKeys) {
   EXPECT_EQ(expected, json.dump());
 }
 
-TEST(JsonUtilsTest, RemoveEmptyArrays) {
-  std::vector<std::string> keys = {"start_time", "query_parameters"};
-  auto constexpr kJsonText =
-      R"({"start_time":"10", "project_id": "1", "query_parameters":[]})";
-
-  auto json = RemoveJsonKeysAndEmptyFields(kJsonText, keys);
-  auto const* expected = R"({"project_id":"1"})";
-
-  EXPECT_EQ(expected, json.dump());
-}
-
 TEST(JsonUtilsTest, RemoveEmptyObjects) {
   std::vector<std::string> keys = {"start_time", "query"};
   auto constexpr kJsonText =
