SONARPY-664 Rule S5781: Expressions creating sets should not have dup…#723
Merged
Conversation
03bb89a to
5061b57
Compare
gyula-sallai-sonarsource
approved these changes
May 19, 2020
gyula-sallai-sonarsource
left a comment
Contributor
There was a problem hiding this comment.
LGTM, added one minor suggestion.
| context.registerSyntaxNodeConsumer(Tree.Kind.SET_LITERAL, ctx -> { | ||
| SetLiteral setLiteral = (SetLiteral) ctx.syntaxNode(); | ||
| Set<Integer> issueIndexes = new HashSet<>(); | ||
| if (setLiteral.elements().size() > 100) { |
Contributor
There was a problem hiding this comment.
minor I would add this as a constant with a name indicative of why it was introduced.
|
Kudos, SonarQube Quality Gate passed! |
hashicorp-vault-sonar-prod Bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
…items or keys expect wrongly a positional argument (#723) GitOrigin-RevId: af439fbf65cb8a525ffb4bbc878d82cc0ea8ff7a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…licate values