Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SolidCode/SolidPython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SolidCode/SolidPython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/sp_61_customizer_20210529
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 13 files changed
  • 1 contributor

Commits on May 29, 2021

  1. First commit of some code that enables the OpenSCAD Customizer interf… 

    …ace.
    @etjones
    etjones committed May 29, 2021
    Configuration menu
    Copy the full SHA
    8f68ce1 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Customizer progress. Added Dropdowns, Checkboxes, Text boxes & exampl… 

    …es. Next: unit tests
    @etjones
    etjones committed May 31, 2021
    Configuration menu
    Copy the full SHA
    be7867e View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. moved assertEqualNoWhitespace() and assertEqualOpenScadObject() t… 

    …o ExpandedTestCase
    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    d7a0717 View commit details
    Browse the repository at this point in the history

  2. No backslashes in Path strings, even on Windows

    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    bbd7d3f View commit details
    Browse the repository at this point in the history

  3. customizer inits only take up a line if there are any customizer elem… 

    …ents
    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    2b3e5d9 View commit details
    Browse the repository at this point in the history

  4. moved most tests over to self.assertEqualOpenScadObject(), which sa… 

    …ves some boilerplate and lets us focus on logic rather than formatting
    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    8cf8114 View commit details
    Browse the repository at this point in the history

  5. added test_customizer.py. Note the errors we still throw here; that's… 

    … a problem in how Customizer subclasses and CompoundFloat subclasses interact. We want any float operating on a CompountFloat to become a CompoundFloat as well, but we also want to output an instance's name when used in OpenSCAD code, which isn't happening correctly yet. Yay for tests!
    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    95d5439 View commit details
    Browse the repository at this point in the history

  6. Renamed ExtendedTestCase.DiffOutput to solidpython_testcase.SolidPyth… 

    …onTestCase, which is more consistent
    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    98ecbeb View commit details
    Browse the repository at this point in the history

  7. Completed first pass at Customizer features.

    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    3e544a8 View commit details
    Browse the repository at this point in the history

  8. Updated scad_tokens.py to remove some DeprecationWarnings

    @etjones
    etjones committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    07a6138 View commit details
    Browse the repository at this point in the history
Loading