Skip to content

Commit 5f1965c

Browse files
committed
Fix retry loop in hosted-e2e by disabling errexit during cargo test
The retry loop was ineffective because GitHub Actions uses bash -e by default. When cargo test failed, the script would exit immediately before capturing the exit status, preventing attempts 2 and 3 from running. Added set +e before the test command and set -e after capturing status to allow the retry logic to function correctly.
1 parent 13e5442 commit 5f1965c

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,9 +916,11 @@ jobs:
916916
# transient 503 does not block merges through a required check.
917917
for attempt in 1 2 3; do
918918
echo "::group::hosted-e2e attempt $attempt"
919+
set +e
919920
cargo test -p socket-patch-cli --test e2e_hosted_production -- \
920921
--ignored --nocapture --test-threads=4
921922
status=$?
923+
set -e
922924
echo "::endgroup::"
923925
if [ "$status" -eq 0 ]; then
924926
exit 0

0 commit comments

Comments
 (0)