test: tighten vacuous assertions in cacache and spinner

jdalton · jdalton · commit 757717d39db8 · 2026-04-18T11:23:36.000-04:00
- cacache.test.mts: drop toBeDefined on cacache.rm/ls — subsequent
  typeof check on rm.entry/ls.stream already enforces the namespaces exist
- spinner.test.mts: consolidate 4 near-duplicate 'should accept X theme'
  tests into one it.each; strengthen getCliSpinners socket test to assert
  frames is an array and interval is a number instead of just toBeDefined
diff --git a/test/unit/cacache.test.mts b/test/unit/cacache.test.mts
@@ -44,8 +44,6 @@ describe('cacache', () => {
       expect(typeof cacache.get).toBe('function')
       expect(typeof cacache.put).toBe('function')
       // rm and ls are namespaces with methods like rm.entry, rm.all, ls.stream
-      expect(cacache.rm).toBeDefined()
-      expect(cacache.ls).toBeDefined()
       expect(typeof cacache.rm.entry).toBe('function')
       expect(typeof cacache.ls.stream).toBe('function')
     })
diff --git a/test/unit/spinner.test.mts b/test/unit/spinner.test.mts
@@ -756,33 +756,22 @@ describe('spinner', () => {
   })
 
   describe('Theme handling', () => {
-    it('should accept theme as string name', () => {
-      const spinner = Spinner({ theme: 'socket' })
-      expect(spinner).toBeDefined()
-    })
-
-    it('should accept theme lush', () => {
-      const spinner = Spinner({ theme: 'lush' })
-      expect(spinner).toBeDefined()
-    })
-
-    it('should accept theme sunset', () => {
-      const spinner = Spinner({ theme: 'sunset' })
-      expect(spinner).toBeDefined()
-    })
-
-    it('should accept theme ultra', () => {
-      const spinner = Spinner({ theme: 'ultra' })
-      expect(spinner).toBeDefined()
-    })
+    it.each(['socket', 'lush', 'sunset', 'ultra'] as const)(
+      'should accept %s theme name without throwing and return a spinner with methods',
+      themeName => {
+        const spinner = Spinner({ theme: themeName })
+        expect(typeof spinner.start).toBe('function')
+        expect(typeof spinner.stop).toBe('function')
+      },
+    )
   })
 
   describe('getCliSpinners', () => {
     it('should return socket custom spinner', () => {
       const socket = getCliSpinners('socket')
       expect(socket).toBeDefined()
-      expect(socket!.frames).toBeDefined()
-      expect(socket!.interval).toBeDefined()
+      expect(Array.isArray(socket!.frames)).toBe(true)
+      expect(typeof socket!.interval).toBe('number')
     })
 
     it('should return undefined for non-existent spinner', () => {
