Skip to content

Commit 873e91e

Browse files
committed
* ev_ref -> uv_ref
* remove 0.2.x Buffer compatibility
1 parent 25388bc commit 873e91e

5 files changed

Lines changed: 8 additions & 19 deletions

File tree

src/async.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@ template <class Item, class Parent> class Async {
3030
rows.swap(async->data);
3131
pthread_mutex_unlock(&async->mutex);
3232
for (unsigned int i = 0, size = rows.size(); i < size; i++) {
33-
ev_unref(EV_DEFAULT_UC);
33+
uv_unref(uv_default_loop());
3434
async->callback(async->parent, rows[i]);
3535
}
3636
}
3737

3838
inline void add(Item* item) {
3939
// Make sure node runs long enough to deliver the messages.
40-
ev_ref(EV_DEFAULT_UC);
40+
uv_ref(uv_default_loop());
4141
pthread_mutex_lock(&mutex);
4242
data.push_back(item);
4343
pthread_mutex_unlock(&mutex);

src/database.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ void Database::Destruct(Persistent<Value> value, void *data) {
657657

658658
if (db->handle) {
659659
eio_custom(EIO_Destruct, EIO_PRI_DEFAULT, EIO_AfterDestruct, db);
660-
ev_ref(EV_DEFAULT_UC);
660+
uv_ref(uv_default_loop());
661661
}
662662
else {
663663
delete db;
@@ -673,7 +673,7 @@ void Database::EIO_Destruct(eio_req *req) {
673673

674674
int Database::EIO_AfterDestruct(eio_req *req) {
675675
Database* db = static_cast<Database*>(req->data);
676-
ev_unref(EV_DEFAULT_UC);
676+
uv_unref(uv_default_loop());
677677
delete db;
678678
return 0;
679679
}

src/database.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ class Database : public ObjectWrap {
3838
Baton(Database* db_, Handle<Function> cb_) :
3939
db(db_), status(SQLITE_OK) {
4040
db->Ref();
41-
ev_ref(EV_DEFAULT_UC);
41+
uv_ref(uv_default_loop());
4242
callback = Persistent<Function>::New(cb_);
4343
}
4444
virtual ~Baton() {
4545
db->Unref();
46-
ev_unref(EV_DEFAULT_UC);
46+
uv_unref(uv_default_loop());
4747
callback.Dispose();
4848
}
4949
};

src/statement.cc

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
#include <v8.h>
33
#include <node.h>
44
#include <node_buffer.h>
5-
#include <node_version.h>
65

76
#include "macros.h"
87
#include "database.h"
@@ -185,13 +184,8 @@ template <class T> Values::Field*
185184
return new Values::Null(pos);
186185
}
187186
else if (Buffer::HasInstance(source)) {
188-
#if NODE_VERSION_AT_LEAST(0,3,0)
189187
Local<Object> buffer = source->ToObject();
190188
return new Values::Blob(pos, Buffer::Length(buffer), Buffer::Data(buffer));
191-
#else
192-
Buffer* buffer = ObjectWrap::Unwrap<Buffer>(source->ToObject());
193-
return new Values::Blob(pos, buffer->length(), buffer->data());
194-
#endif
195189
}
196190
else if (source->IsDate()) {
197191
return new Values::Float(pos, source->NumberValue());
@@ -774,12 +768,7 @@ Local<Object> Statement::RowToJS(Row* row) {
774768
value = Local<Value>(String::New(((Values::Text*)field)->value.c_str(), ((Values::Text*)field)->value.size()));
775769
} break;
776770
case SQLITE_BLOB: {
777-
#if NODE_VERSION_AT_LEAST(0,3,0)
778771
Buffer *buffer = Buffer::New(((Values::Blob*)field)->value, ((Values::Blob*)field)->length);
779-
#else
780-
Buffer *buffer = Buffer::New(((Values::Blob*)field)->length);
781-
memcpy(buffer->data(), ((Values::Blob*)field)->value, buffer->length());
782-
#endif
783772
value = Local<Value>::New(buffer->handle_);
784773
} break;
785774
case SQLITE_NULL: {

src/statement.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class Statement : public ObjectWrap {
8585

8686
Baton(Statement* stmt_, Handle<Function> cb_) : stmt(stmt_) {
8787
stmt->Ref();
88-
ev_ref(EV_DEFAULT_UC);
88+
uv_ref(uv_default_loop());
8989
callback = Persistent<Function>::New(cb_);
9090
}
9191
virtual ~Baton() {
@@ -94,7 +94,7 @@ class Statement : public ObjectWrap {
9494
DELETE_FIELD(field);
9595
}
9696
stmt->Unref();
97-
ev_unref(EV_DEFAULT_UC);
97+
uv_unref(uv_default_loop());
9898
callback.Dispose();
9999
}
100100
};

0 commit comments

Comments
 (0)