Skip to content

Commit 7fe335d

Browse files
author
Kuniwak
committed
Refactor lint configs
1 parent d22056d commit 7fe335d

File tree

9 files changed

+27
-74
lines changed

9 files changed

+27
-74
lines changed

‎.eslintrc‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,13 @@
33
"node": true
44
},
55
"rules": {
6-
"quotes": [2, "single"],
7-
"no-use-before-define": 0
6+
"//": "single quote に統一",
7+
"quotes": [2, "single", "avoid-escape"],
8+
9+
"//": "関数宣言文以外は hoisting 避けのため禁止",
10+
"no-use-before-define": [2, "nofunc"],
11+
12+
"//": "この形式のキャストはくっついていないと読みづらい",
13+
"space-infix-ops": [2, { "int32Hint": false }]
814
}
915
}

‎public/.eslintrc‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,14 @@
11
{
22
"env": {
3-
"mocha": true
3+
"mocha": true,
4+
"browser": true,
5+
"jquery": true
46
},
57
"globals": {
68
"expect": false
9+
},
10+
"rules": {
11+
"//": "chai の expect 構文が誤警告になるため無視",
12+
"no-unused-expressions": 0
713
}
814
}

‎public/stage1/.eslintrc‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎public/stage2/.eslintrc‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎public/stage3/.eslintrc‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎public/stage4/.eslintrc‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎public/stage5/.eslintrc‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,6 @@
11
{
2-
"env": {
3-
"browser": true,
4-
"mocha": true
5-
},
62
"globals": {
7-
"$": false,
8-
"jQuery": false,
93
"fetch": false,
10-
"Promise": false,
11-
"HTMLCollection": false
4+
"Promise": false
125
}
136
}

‎public/stage6/.eslintrc‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,10 @@
11
{
2-
"env": {
3-
"browser": true,
4-
"mocha": true
5-
},
62
"rules": {
7-
"no-unused-expressions": 0,
3+
"//": "シャレオツコードの意図が undefined 代入だとわかりやすいので許可",
84
"no-undef-init": 0
95
},
106
"globals": {
11-
"$": false,
12-
"jQuery": false,
137
"fetch": false,
14-
"Promise": false,
15-
"HTMLCollection": false
8+
"Promise": false
169
}
1710
}

‎public/stage7/.eslintrc‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
{
2-
"env": {
3-
"browser": true,
4-
"mocha": true
5-
},
62
"rules": {
7-
"no-unused-expressions": 0,
8-
"no-undef-init": 0
3+
"//": "undefined 上書き問題のため、明示的な undefined 代入を許可",
4+
"no-undef-init": 0,
5+
6+
"//": "== 演算子の振る舞いの問題の警告は誤警告",
7+
"yoda": 0,
8+
9+
"//": "truthy, falsey を判定する問題のため、定数式を許可",
10+
"no-constant-condition": 0
911
},
1012
"globals": {
11-
"$": false,
12-
"jQuery": false,
1313
"fetch": false,
14-
"Promise": false,
15-
"HTMLCollection": false
14+
"Promise": false
1615
}
1716
}

0 commit comments

Comments
 (0)