[r] switch to StringConverter

i4004 · i4004 · commit 52ab67e58787 · 2024-05-19T22:20:20.000+05:00
diff --git a/src/Simplify.Web/Controllers/V2/Routing/Controller2PathParser.cs b/src/Simplify.Web/Controllers/V2/Routing/Controller2PathParser.cs
@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Text.RegularExpressions;
 using Simplify.Web.Controllers.Meta.Routing;
+using Simplify.Web.System;
 
 namespace Simplify.Web.Controllers.V2.Routing;
 
@@ -12,18 +13,6 @@ public static class Controller2PathParser
 
 	private static readonly char[] RequiredSymbols = ['{', '}'];
 
-	public static IList<Type> SupportedTypes { get; } =
-	[
-		typeof(string),
-		typeof(int),
-		typeof(decimal),
-		typeof(bool),
-		typeof(string[]),
-		typeof(int[]),
-		typeof(decimal[]),
-		typeof(bool[])
-	];
-
 	/// <summary>
 	/// Parses the specified controller path.
 	/// </summary>
@@ -70,11 +59,10 @@ private static PathItem ParsePathParameter(string item, string controllerPath, I
 		if (!invokeMethodParameters.TryGetValue(parameterName, out var parameterType))
 			return new PathParameter(parameterName, typeof(string));
 
-		if (!SupportedTypes.Contains(parameterType))
-			throw new ControllerRouteException($"Unsupported parameter type '{parameterType.Name}' of parameter '{parameterName}'. Can be one of: {GetTypeNamesAsString()}");
+		if (!StringConverter.ValueConverters.ContainsKey(parameterType))
+			throw new ControllerRouteException(
+				$"Unsupported parameter type '{parameterType.Name}' of parameter '{parameterName}'. Can be one of: {StringConverter.GetSupportedTypeNamesAsString()}");
 
 		return new PathParameter(parameterName, parameterType);
 	}
-
-	private static string GetTypeNamesAsString() => string.Join(", ", SupportedTypes.Select(type => type.Name));
 }
diff --git a/src/Simplify.Web/System/StringConverter.cs b/src/Simplify.Web/System/StringConverter.cs
@@ -6,7 +6,7 @@ namespace Simplify.Web.System;
 
 public static class StringConverter
 {
-	private static readonly Dictionary<Type, Func<string, object?>> ValueConverters =
+	public static readonly Dictionary<Type, Func<string, object?>> ValueConverters =
 		new()
 		{
 			{ typeof(string), sourceValue => sourceValue },
@@ -27,6 +27,8 @@ public static class StringConverter
 			? converter(sourceValue)
 			: null;
 
+	public static string GetSupportedTypeNamesAsString() => string.Join(", ", ValueConverters.Keys.Select(type => type.Name));
+
 	private static object? GetIntParameterValue(string source)
 	{
 		if (!int.TryParse(source, out var buffer))

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace Simplify.Web.System;`
`6`	`6`
`7`	`7`	`public static class StringConverter`
`8`	`8`	`{`
`9`		`- private static readonly Dictionary<Type, Func<string, object?>> ValueConverters =`
	`9`	`+ public static readonly Dictionary<Type, Func<string, object?>> ValueConverters =`
`10`	`10`	`new()`
`11`	`11`	`{`
`12`	`12`	`{ typeof(string), sourceValue => sourceValue },`
`@@ -27,6 +27,8 @@ public static class StringConverter`
`27`	`27`	`? converter(sourceValue)`
`28`	`28`	`: null;`
`29`	`29`
	`30`	`+ public static string GetSupportedTypeNamesAsString() => string.Join(", ", ValueConverters.Keys.Select(type => type.Name));`
	`31`	`+`
`30`	`32`	`private static object? GetIntParameterValue(string source)`
`31`	`33`	`{`
`32`	`34`	`if (!int.TryParse(source, out var buffer))`